From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] net: dsa: ksz9477: fix confusing message detecting KSZ9893 compatible
Date: Tue, 10 Jan 2023 15:32:47 +0100 [thread overview]
Message-ID: <20230110143247.GD28911@pengutronix.de> (raw)
In-Reply-To: <20230110133817.3939707-1-a.fatoum@pengutronix.de>
On Tue, Jan 10, 2023 at 02:38:16PM +0100, Ahmad Fatoum wrote:
> I have a KSZ8563RNXI-TR, which while it works, barebox reports as
> "Found KSZ9893", which is a bit confusing. For non-KSZ9893, barebox
> reports "Found KSZ9477 or compatible", so do likewise for KSZ9893.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> drivers/net/ksz9477.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/net/ksz9477.c b/drivers/net/ksz9477.c
> index b3859e13bf13..0629efbd7d02 100644
> --- a/drivers/net/ksz9477.c
> +++ b/drivers/net/ksz9477.c
> @@ -82,7 +82,7 @@ static int ksz9477_switch_detect(struct ksz_switch *priv)
> id_lo = (u8)(id32 >> 8);
> if ((id_lo & 0xf) == 3) {
> /* Chip is from KSZ9893 design. */
> - dev_info(priv->dev, "Found KSZ9893\n");
> + dev_info(priv->dev, "Found KSZ9893 or compatible\n");
> priv->features |= IS_9893;
> priv->features &= ~KSZ9477_PHY_ERRATA;
>
> --
> 2.30.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2023-01-10 14:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 13:38 Ahmad Fatoum
2023-01-10 13:38 ` [PATCH 2/2] net: dsa: ksz9477: match microchip,ksz8563 compatible Ahmad Fatoum
2023-01-10 14:32 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110143247.GD28911@pengutronix.de \
--to=sha@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox