mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC PATCH 2/2] net: ifup: have ifup -a stop at the first interface
Date: Thu, 26 Jan 2023 09:36:13 +0100	[thread overview]
Message-ID: <20230126083613.GM13319@pengutronix.de> (raw)
In-Reply-To: <20230125095236.2626065-2-a.fatoum@pengutronix.de>

On Wed, Jan 25, 2023 at 10:52:36AM +0100, Ahmad Fatoum wrote:
> The normal use case for ifup -a is to get *some* interface working and
> not really wait for all interfaces to come up and then timeout waiting
> for those without link up to get their DHCP lease. Thus repurpose ifup
> -a to mean bring up all interfaces until first success with the new
> ifup -A restoring the old behavior.

I am not very keen on changing the meaning of the -a option. We should
rather keep -a like it is and add a new option for your purpose, like
-s (for "s"ome interface) or -o ("o"ne interface).
The occurences of "ifup -a" in the tree can/should be changed then
accordingly as well.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



  reply	other threads:[~2023-01-26  8:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-25  9:52 [RFC PATCH 1/2] net: ifup: prefer interfaces where the link is already up Ahmad Fatoum
2023-01-25  9:52 ` [RFC PATCH 2/2] net: ifup: have ifup -a stop at the first interface Ahmad Fatoum
2023-01-26  8:36   ` Sascha Hauer [this message]
2023-01-26  8:31 ` [RFC PATCH 1/2] net: ifup: prefer interfaces where the link is already up Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230126083613.GM13319@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox