Re: [PATCH] ARM: dts: i.MX8MP: remove memory node

[Marco Felsch <m.felsch@pengutronix.de>]

On 23-03-13, Lucas Stach wrote:
> Am Sonntag, dem 12.03.2023 um 17:29 +0100 schrieb Marco Felsch:
> > since commit f083fffe52 ("ARM: dts: i.MX8MP: add DDRC compatibles") we
> > make use of the esdctl driver. This cause the below error since barebox
> > try to add the memory twice.
> > 
> > > imx-esdctl 3d400000.memory-controller@3d400000.of: probe failed: Device or resource busy
> > > initcall imx_esdctl_driver_init+0x0/0x2c failed: No such device
> > 
> I wonder why I didn't hit this. Probably some probe order thing.

I think this is because of the fact that the boards do add the memory
node not the 8mp.dtsi and the debix don't have such a node.

> > Remove the memory node to fix this.
> > 
> > This behaviour was seen on a i.mx8mp-evk but the
> > imx8mp-tqma8mpql-mba8mpxl also has a memory node and includes the
> > barebox.dtsi.
> > 
> > Fixes: f083fffe52 ("ARM: dts: i.MX8MP: add DDRC compatibles")
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > ---
> >  arch/arm/dts/imx8mp-evk.dts                | 2 ++
> >  arch/arm/dts/imx8mp-tqma8mpql-mba8mpxl.dts | 2 ++
> >  2 files changed, 4 insertions(+)
> > 
> > diff --git a/arch/arm/dts/imx8mp-evk.dts b/arch/arm/dts/imx8mp-evk.dts
> > index 0acc3731d5..c7e1f35d2d 100644
> > --- a/arch/arm/dts/imx8mp-evk.dts
> > +++ b/arch/arm/dts/imx8mp-evk.dts
> > @@ -30,6 +30,8 @@
> >  	};
> >  };
> >  
> > +/delete-node/ &{/memory@40000000};
> > +
> Why not add this to arch/arm/dts/imx8mp.dtsi?

What does the compiler if ther is no such node? If the compiler just
ignore deleting not exisiting nodes I'm fine with your proposal. Thanks
for the review.

Regards,
  Marco

> 
> Regards,
> Lucas
> 
> >  &ethphy1 {
> >  	reset-assert-us = <15000>;
> >  	reset-deassert-us = <100000>;
> > diff --git a/arch/arm/dts/imx8mp-tqma8mpql-mba8mpxl.dts b/arch/arm/dts/imx8mp-tqma8mpql-mba8mpxl.dts
> > index 6e81f58e27..bf23e40489 100644
> > --- a/arch/arm/dts/imx8mp-tqma8mpql-mba8mpxl.dts
> > +++ b/arch/arm/dts/imx8mp-tqma8mpql-mba8mpxl.dts
> > @@ -24,6 +24,8 @@
> >  	};
> >  };
> >  
> > +/delete-node/ &{/memory@40000000};
> > +
> >  &usdhc2 {
> >  	#address-cells = <1>;
> >  	#size-cells = <1>;
> 
>