mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH] usb: dwc3: gadget: lower informal user notifaction dequeue operation
Date: Thu, 23 Mar 2023 18:30:16 +0100	[thread overview]
Message-ID: <20230323173016.4089191-1-m.felsch@pengutronix.de> (raw)

I encounted the below error message on the i.MX8MP if a fastboot gadget
was up and running and barebox does a reset() or boots the kernel:

  ERROR: dwc3 38100000.usb@38100000.of: request 00000000bfd91568 was not queued to ep1out

Printing an error message during usb_ep_dequeue() is more confusing than
helpful since the usb_ep_dequeue() could be called during unbind() like
it is done for fastboot. Lower the dev_err() message to dev_dbg() to
keep the message for developers.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 drivers/usb/dwc3/gadget.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 48be74f7e9..ffe4f30c67 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -1955,7 +1955,7 @@ static int dwc3_gadget_ep_dequeue(struct usb_ep *ep,
 		}
 	}
 
-	dev_err(dwc->dev, "request %pK was not queued to %s\n",
+	dev_dbg(dwc->dev, "request %pK was not queued to %s\n",
 		request, ep->name);
 	ret = -EINVAL;
 out:
-- 
2.30.2




             reply	other threads:[~2023-03-23 17:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23 17:30 Marco Felsch [this message]
2023-03-24  8:30 ` Sascha Hauer
2023-03-24  8:39   ` Marco Felsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230323173016.4089191-1-m.felsch@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox