mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: boards: protonic-imx6: fix bbu_handler device paths
Date: Tue, 4 Apr 2023 09:05:32 +0200	[thread overview]
Message-ID: <20230404070532.GV19113@pengutronix.de> (raw)
In-Reply-To: <20230403122509.258800-1-m.felsch@pengutronix.de>

On Mon, Apr 03, 2023 at 02:25:09PM +0200, Marco Felsch wrote:
> The update handler path must be a full-path starting at '/'. Fix this by
> adding the '/dev/' path prefix.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  arch/arm/boards/protonic-imx6/board.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/arch/arm/boards/protonic-imx6/board.c b/arch/arm/boards/protonic-imx6/board.c
> index d2fb25d3cc..0d57f409d2 100644
> --- a/arch/arm/boards/protonic-imx6/board.c
> +++ b/arch/arm/boards/protonic-imx6/board.c
> @@ -530,7 +530,7 @@ static int prt_imx6_bbu(struct prt_imx6_priv *priv)
>  		emmc_flags = BBU_HANDLER_FLAG_DEFAULT;
>  	}
>  
> -	devicefile = basprintf("mmc%d", dcfg->emmc_usdhc);
> +	devicefile = basprintf("/dev/mmc%d", dcfg->emmc_usdhc);
>  	if (!devicefile) {
>  		ret = -ENOMEM;
>  		goto exit_bbu;
> @@ -540,7 +540,7 @@ static int prt_imx6_bbu(struct prt_imx6_priv *priv)
>  	if (ret)
>  		goto exit_bbu;
>  
> -	devicefile = basprintf("mmc%d", dcfg->sd_usdhc);
> +	devicefile = basprintf("/dev/mmc%d", dcfg->sd_usdhc);
>  	if (!devicefile) {
>  		ret = -ENOMEM;
>  		goto exit_bbu;
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



      reply	other threads:[~2023-04-04  7:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-03 12:25 Marco Felsch
2023-04-04  7:05 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230404070532.GV19113@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=m.felsch@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox