mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH master] ARM: rockchip: don't attempt building MACH_RADXA_ROCK5 without firmware
Date: Tue, 23 May 2023 11:41:24 +0200	[thread overview]
Message-ID: <20230523094124.3453658-1-a.fatoum@pengutronix.de> (raw)

Otherwise, multi_v8_defconfig would give errors for users that are only
interested in using it for qemu-virt64, which requires no external
firmware to be built into barebox.

While at it, fix spaces to tabs to be in-line with the rest of the file.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 arch/arm/mach-rockchip/Kconfig | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
index 38736102d334..a71c4ae35dd9 100644
--- a/arch/arm/mach-rockchip/Kconfig
+++ b/arch/arm/mach-rockchip/Kconfig
@@ -102,9 +102,10 @@ config MACH_RADXA_ROCK3
 	  Say Y here if you are using a Radxa ROCK3
 
 config MACH_RADXA_ROCK5
-       select ARCH_RK3588
-       bool "Radxa ROCK5"
-       help
+	select ARCH_RK3588
+	depends on $(success,test -e $(srctree)/arch/arm/boards/radxa-rock5/sdram-init.bin)
+	bool "Radxa ROCK5"
+	help
 	  Say Y here if you are using a Radxa ROCK5
 
 config MACH_RADXA_CM3
-- 
2.39.2




             reply	other threads:[~2023-05-23  9:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-23  9:41 Ahmad Fatoum [this message]
2023-05-25  6:49 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230523094124.3453658-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox