mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Oleksij Rempel <>
Cc: Oleksij Rempel <>
Subject: [PATCH v1 2/2] net: ksz9477: do not advertise EEE support
Date: Fri, 11 Aug 2023 13:53:25 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Do not advertise EEE support for all ksz9477 based chips. EEE needs
proper handling which we can't guarantee with limited resources.

At same time remove wrong comment and Gbit check. EEE is not coupled to
Gbit and KSZ8565 supports EEE as well. So, it seems like there is
nothing right on this comment.

Signed-off-by: Oleksij Rempel <>
 drivers/net/ksz9477.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ksz9477.c b/drivers/net/ksz9477.c
index a6a8144479..9665e0f723 100644
--- a/drivers/net/ksz9477.c
+++ b/drivers/net/ksz9477.c
@@ -175,12 +175,6 @@ static void ksz9477_phy_errata_setup(struct ksz_switch *priv, int port)
 	ksz9477_port_mmd_write(priv, port, 0x1c, 0x04, 0x00d0);
-	/* Energy Efficient Ethernet (EEE) feature select must
-	 * be manually disabled (except on KSZ8565 which is 100Mbit)
-	 */
-	if (priv->features & GBIT_SUPPORT)
-		ksz9477_port_mmd_write(priv, port, 0x07, 0x3c, 0x0000);
 	/* Register settings are required to meet data sheet
 	 * supply current specifications
@@ -269,6 +263,8 @@ static int ksz_port_setup(struct ksz_switch *priv, int port,
 		if (priv->features & KSZ9477_PHY_ERRATA)
 			ksz9477_phy_errata_setup(priv, port);
+		ksz9477_port_mmd_write(priv, port, 0x07, 0x3c, 0x0000);
 		ksz_pwrite16(priv, port, 0x100 + (MII_BMCR << 1),
 	} else {

  reply	other threads:[~2023-08-11 11:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-11 11:53 [PATCH v1 1/2] net: ksz9477: add support for ksz9893 switch Oleksij Rempel
2023-08-11 11:53 ` Oleksij Rempel [this message]
2023-08-11 12:50 ` Ahmad Fatoum
2023-08-14  5:54 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox