mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@barebox.org>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@barebox.org>
Subject: [PATCH 3/7] commands: fbtest: add flush for single pattern
Date: Mon, 13 Apr 2026 09:44:46 +0200	[thread overview]
Message-ID: <20260413074522.1410710-4-a.fatoum@barebox.org> (raw)
In-Reply-To: <20260413074522.1410710-1-a.fatoum@barebox.org>

The single-pattern else-branch calls gu_screen_blit() to copy the render
buffer to the framebuffer in-memory image, but never called fb_flush()
to make sure the image makes it to display RAM.

Add fb_flush(sc->info) after gu_screen_blit(), matching the cycling
path above.

Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
 commands/fbtest.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/commands/fbtest.c b/commands/fbtest.c
index cee72b039371..40c97f72a442 100644
--- a/commands/fbtest.c
+++ b/commands/fbtest.c
@@ -297,6 +297,7 @@ static int do_fbtest(int argc, char *argv[])
 	} else {
 		pattern(sc, color);
 		gu_screen_blit(sc);
+		fb_flush(sc->info);
 	}
 done:
 	fb_close(sc);
-- 
2.47.3




  parent reply	other threads:[~2026-04-13  7:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-13  7:44 [PATCH 0/7] test: Add framebuffer test Ahmad Fatoum
2026-04-13  7:44 ` [PATCH 1/7] ARM: multi_v8_defconfig: enable QEMU ramfb driver Ahmad Fatoum
2026-04-13  7:44 ` [PATCH 2/7] test: enable VirtIO keyboard Ahmad Fatoum
2026-04-13  7:44 ` Ahmad Fatoum [this message]
2026-04-13  7:44 ` [PATCH 4/7] test: conftest: don't call .startswith on int Ahmad Fatoum
2026-04-13  7:44 ` [PATCH 5/7] test: conftest: set -display none when non-interactive Ahmad Fatoum
2026-04-13  7:44 ` [PATCH 6/7] test: conftest: add qemu feature Ahmad Fatoum
2026-04-13  7:44 ` [PATCH 7/7] test: add framebuffer screenshot testing via QMP screendump Ahmad Fatoum
2026-04-22  8:01 ` [PATCH 0/7] test: Add framebuffer test Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260413074522.1410710-4-a.fatoum@barebox.org \
    --to=a.fatoum@barebox.org \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox