From: Ahmad Fatoum <a.fatoum@barebox.org>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@barebox.org>
Subject: [PATCH] efi: gop: use screen_base directly instead of shadow buffer
Date: Mon, 13 Apr 2026 22:03:26 +0200 [thread overview]
Message-ID: <20260413200330.1558038-1-a.fatoum@barebox.org> (raw)
The EFI GOP protocol operates on the hardware framebuffer and calls
fb_damage() to notify the driver of updates. Using fb_get_screen_base()
would return the shadow buffer when enabled, causing GOP writes to go
into the shadow instead of the actual framebuffer.
Do as the simplefb fixup does and use the screen_base.
Fixes: d040f49ad0b3 ("efi: loader: protocol: add graphical output protocol support")
Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
efi/loader/protocols/gop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/efi/loader/protocols/gop.c b/efi/loader/protocols/gop.c
index 2d87acc9bcc7..5bceb3f68f0f 100644
--- a/efi/loader/protocols/gop.c
+++ b/efi/loader/protocols/gop.c
@@ -558,7 +558,7 @@ static efi_status_t efi_gop_register(void *data)
pixel_information->blue_mask = 0x001f;
}
gopobj->info.pixels_per_scan_line = col;
- gopobj->fb = fb_get_screen_base(fbi);
+ gopobj->fb = fbi->screen_base;
gopobj->fbi = fbi;
return EFI_SUCCESS;
--
2.47.3
next reply other threads:[~2026-04-13 20:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 20:03 Ahmad Fatoum [this message]
2026-04-15 6:39 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260413200330.1558038-1-a.fatoum@barebox.org \
--to=a.fatoum@barebox.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox