mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH] mci: add missing break
Date: Wed, 15 Apr 2026 10:13:57 +0200	[thread overview]
Message-ID: <20260415081357.450925-1-s.hauer@pengutronix.de> (raw)

65077d2078 adds a new case to a switch/case which lacks a break, so it
falls through and EXT_CSD_REV = 0 is detected as MMC_VERSION_4_1 instead
of MMC_VERSION_4. Add the missing break.

Fixes: 65077d2078 ("mci: treat unknown MMC version as greater than known versions")
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/mci/mci-core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
index d3d7bd5e07..babb180ab1 100644
--- a/drivers/mci/mci-core.c
+++ b/drivers/mci/mci-core.c
@@ -1160,6 +1160,7 @@ static void mci_correct_version_from_ext_csd(struct mci *mci)
 		switch (mci->ext_csd[EXT_CSD_REV]) {
 		case 0:
 			mci->version = MMC_VERSION_4;
+			break;
 		case 1:
 			mci->version = MMC_VERSION_4_1;
 			break;
-- 
2.47.3




             reply	other threads:[~2026-04-15  8:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-15  8:13 Sascha Hauer [this message]
2026-04-17  9:08 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260415081357.450925-1-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox