mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH] fs: Do not mntput() the root device parent
Date: Wed, 15 Apr 2026 15:08:54 +0200	[thread overview]
Message-ID: <20260415130854.3826102-1-s.hauer@pengutronix.de> (raw)

The vfs rootfs ("/") parent points to itself, so do not call mntput() on
the parent when it's the root device as the reference counter would
become negative.

This doesn't happen in normal configurations as we normally have a ramfs
mounted at / and we leave fs_remove() early in that case. Some xload
configurations have a FAT from SD/eMMC mounted at / though which leads
to a "refcount for mount \"%s\" becomes negative\n" warning.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 fs/fs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/fs.c b/fs/fs.c
index f1f69a501f..a562fe0fc6 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -874,7 +874,8 @@ static void fs_remove(struct device *dev)
 	list_for_each_entry_safe(inode, tmp, &sb->s_inodes, i_sb_list)
 		destroy_inode(inode);
 
-	mntput(fsdev->vfsmount.parent);
+	if (&fsdev->vfsmount != fsdev->vfsmount.parent)
+		mntput(fsdev->vfsmount.parent);
 
 	free(fsdev->backingstore);
 }
-- 
2.47.3




             reply	other threads:[~2026-04-15 13:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-15 13:08 Sascha Hauer [this message]
2026-04-15 13:21 ` Ahmad Fatoum
2026-04-17  8:03 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260415130854.3826102-1-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox