mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>,
	Yunus Taskopru <yunus@protonic.nl>
Subject: [PATCH] ARM: dts: rk3588-rock-5b: fix SD card startup for Radxa ROCK 5B
Date: Fri, 17 Apr 2026 11:56:30 +0200	[thread overview]
Message-ID: <20260417095640.3903125-1-a.fatoum@pengutronix.de> (raw)

Both Rock 5B and 5T share a common rk3588-rock-5b-5bp-5t.dtsi and the
fix in commit bd5518cd7e34 ("ARM: rockchip: fix SD card startup for
Radxa ROCK 5T") is equally applicable to both of them.

As mentioned in the commit message, the upstream pinctrl change broke
the SD card startup and the workaround for now is to revert back to
the previous pinmux setting.

Reported-by: Yunus Taskopru <yunus@protonic.nl>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 arch/arm/dts/rk3588-rock-5b.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/dts/rk3588-rock-5b.dts b/arch/arm/dts/rk3588-rock-5b.dts
index aca675f57f4c..2af8af7ad349 100644
--- a/arch/arm/dts/rk3588-rock-5b.dts
+++ b/arch/arm/dts/rk3588-rock-5b.dts
@@ -78,3 +78,7 @@ &usb_host1_ehci {
 	/* Does not work in barebox (missing phy driver) */
 	status = "disabled";
 };
+
+&sdmmc_det_pin {
+	rockchip,pins = <0 RK_PA4 1 &pcfg_pull_up>;
+};
-- 
2.47.3




             reply	other threads:[~2026-04-17  9:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-17  9:56 Ahmad Fatoum [this message]
2026-04-17 10:46 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260417095640.3903125-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=yunus@protonic.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox