mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Michael Tretter <m.tretter@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
	 BAREBOX <barebox@lists.infradead.org>
Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>,
	 Michael Tretter <m.tretter@pengutronix.de>
Subject: [PATCH 1/2] net: xgmac: switch to upstream compatible
Date: Thu, 23 Apr 2026 08:58:11 +0200	[thread overview]
Message-ID: <20260423-socfpga-agilex5-dwmac-binding-v1-1-19b4b0cddbee@pengutronix.de> (raw)
In-Reply-To: <20260423-socfpga-agilex5-dwmac-binding-v1-0-19b4b0cddbee@pengutronix.de>

The "intel,socfpga-dwxgmac" binding is not defined, but the correct
binding is "altr,socfpga-stmmac-agilex5".

Switch to the correct upstream compatible for the driver.

This breaks backwards compatibility with older and downstream device
trees. Since the binding was never officially defined, implementing the
necessary compatibility isn't worth it.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
 drivers/net/designware_xgmac_socfpga.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/designware_xgmac_socfpga.c b/drivers/net/designware_xgmac_socfpga.c
index 21373c50d962..7598798c5de6 100644
--- a/drivers/net/designware_xgmac_socfpga.c
+++ b/drivers/net/designware_xgmac_socfpga.c
@@ -83,9 +83,9 @@ static int xgmac_probe_resources_socfpga(struct device *dev)
 		dev_err(dev, "Invalid reset line 'stmmaceth'.\n");
 		return PTR_ERR(xgmac->rst);
 	}
-	xgmac->rst_ocp = reset_control_get(dev, "stmmaceth-ocp");
+	xgmac->rst_ocp = reset_control_get(dev, "ahb");
 	if (IS_ERR(xgmac->rst_ocp)) {
-		dev_err(dev, "Invalid reset line 'stmmaceth-ocp'.\n");
+		dev_err(dev, "Invalid reset line 'ahb'.\n");
 		return PTR_ERR(xgmac->rst_ocp);
 	}
 
@@ -139,7 +139,7 @@ struct xgmac_config __maybe_unused xgmac_socfpga_config = {
 
 static __maybe_unused struct of_device_id xgmac_socfpga_compatible[] = {
 	{
-		.compatible = "intel,socfpga-dwxgmac",
+		.compatible = "altr,socfpga-stmmac-agilex5",
 		.data = &xgmac_socfpga_config
 	}, {
 		/* sentinel */

-- 
2.47.3




  reply	other threads:[~2026-04-23  6:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-23  6:58 [PATCH 0/2] ARM: socfpga: xgmac: switch to upstream device tree Michael Tretter
2026-04-23  6:58 ` Michael Tretter [this message]
2026-04-23  6:58 ` [PATCH 2/2] ARM: socfpga: remove obsolete gmac device tree nodes Michael Tretter
2026-04-27  7:23 ` [PATCH 0/2] ARM: socfpga: xgmac: switch to upstream device tree Sascha Hauer
2026-04-27 10:59   ` Michael Tretter
2026-04-27 12:30 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260423-socfpga-agilex5-dwmac-binding-v1-1-19b4b0cddbee@pengutronix.de \
    --to=m.tretter@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    --cc=s.trumtrar@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox