From: Ahmad Fatoum <a.fatoum@barebox.org>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@barebox.org>
Subject: [PATCH] globalvar: call dev_set_param only once when loading nv vars
Date: Fri, 1 May 2026 11:23:51 +0200 [thread overview]
Message-ID: <20260501092355.1056737-2-a.fatoum@barebox.org> (raw)
globalvar_add_simple() accepts NULL as value to mean that a global
variable should be created, but dev_set_param() should not yet be
called.
Instead we pass a non-NULL value, so dev_set_param() is called once when
adding the variable and once more directly after via nv_set().
Fix this, so dev_set_param() is called only once.
Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
common/globalvar.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/globalvar.c b/common/globalvar.c
index 876379b2538e..00f94d98af3d 100644
--- a/common/globalvar.c
+++ b/common/globalvar.c
@@ -236,11 +236,11 @@ static int __nvvar_add(const char *name, const char *value)
if (IS_ERR(p))
return PTR_ERR(p);
}
/* Create corresponding globalvar if it doesn't exist yet */
- ret = globalvar_add_simple(name, value);
+ ret = globalvar_add_simple(name, NULL);
if (ret && ret != -EEXIST)
return ret;
if (value)
return nv_set(p, name, value);
--
2.47.3
reply other threads:[~2026-05-01 9:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260501092355.1056737-2-a.fatoum@barebox.org \
--to=a.fatoum@barebox.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox