mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Johannes Schneider <johannes.schneider@leica-geosystems.com>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Johannes Schneider <johannes.schneider@leica-geosystems.com>
Subject: Re: [RFC] mci: imx-esdhc-pbl: enable ADMA2 for i.MX8M BL33 loads
Date: Tue, 23 Jun 2026 13:02:29 +0000	[thread overview]
Message-ID: <20260623130230.3535941-1-johannes.schneider@leica-geosystems.com> (raw)
In-Reply-To: <8f9e76eb-af18-4ade-adb4-d1deafd6b817@pengutronix.de>

Hoi Ahmad,

> > On 6/19/26 6:09 PM, Johannes Schneider wrote:
> > Add a generic sdhci_enable_adma() helper that lets drivers provide their own
> > descriptor table (so PBL builds can use a static buffer without dma_alloc),
>
> On Rockchip, we already allocate an early malloc pool. I'd rather see
> that we do the same on i.MX PBL as well instead of switching over to
> static buffers.

ACK - early malloc pool rather than the static table, if this comes back.

> You also need to watch out for cache maintenance when you do DMA.
> Not sure how much ends up being empty stubs when you compile for PBL.
> The code was written with the assumption of MMC controller being
> cache-coherent, which is only the case when caches are disabled.
>
> This means:
>
> - Explicit cache handling for streaming DMA
> - Coherent memory for consistent DMA

Right, and the generic helper would need coherent descriptors + streaming
sync to be correct on any MMU-on PBL.
For the record it is not what stalls us here: on the i.MX8M PBL path
the MMU is still off during load_bl33 (we enable it afterwards), so
the descriptor table should already be coherent.



Gruß,
Johannes



      reply	other threads:[~2026-06-23 13:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-19 16:09 [RFC] mci: imx-esdhc-pbl: enable ADMA2 for i.MX8M BL33 loads -- help needed: ADMA stalls in ST_TFR despite every visible register matching the Linux runtime driver Johannes Schneider
2026-06-22  7:11 ` Sascha Hauer
2026-06-23 13:01   ` [RFC] mci: imx-esdhc-pbl: enable ADMA2 for i.MX8M BL33 loads Johannes Schneider
2026-06-22  7:33 ` [RFC] mci: imx-esdhc-pbl: enable ADMA2 for i.MX8M BL33 loads -- help needed: ADMA stalls in ST_TFR despite every visible register matching the Linux runtime driver Ahmad Fatoum
2026-06-23 13:02   ` Johannes Schneider [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260623130230.3535941-1-johannes.schneider@leica-geosystems.com \
    --to=johannes.schneider@leica-geosystems.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox