From: Ahmad Fatoum <a.fatoum@barebox.org>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@barebox.org>
Subject: [PATCH 2/2] nvme: pass device to dma dma_alloc/free_coherent
Date: Thu, 9 Jul 2026 09:22:52 +0200 [thread overview]
Message-ID: <20260709072255.510962-2-a.fatoum@barebox.org> (raw)
In-Reply-To: <20260709072255.510962-1-a.fatoum@barebox.org>
We are already passing the device to the streaming DMA helpers, so do
the same for consistent DMA as well.
Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
drivers/nvme/host/pci.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 29a6db76e0f6..ea582feb1403 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -95,7 +95,7 @@ static int nvme_pci_setup_prps(struct nvme_dev *dev,
if (nprps > dev->prp_pool_size) {
__le64 *prp_pool;
- prp_pool = dma_realloc_coherent(DMA_DEVICE_BROKEN,
+ prp_pool = dma_realloc_coherent(dev->dev,
dev->prp_pool,
dev->prp_pool_size * sizeof(*prp_pool),
nprps * sizeof(*prp_pool),
@@ -164,13 +164,13 @@ static int nvme_alloc_queue(struct nvme_dev *dev, int qid, int depth)
if (dev->ctrl.queue_count > qid)
return 0;
- nvmeq->cqes = dma_alloc_coherent(DMA_DEVICE_BROKEN,
+ nvmeq->cqes = dma_alloc_coherent(dev->dev,
CQ_SIZE(depth),
&nvmeq->cq_dma_addr);
if (!nvmeq->cqes)
goto free_nvmeq;
- nvmeq->sq_cmds = dma_alloc_coherent(DMA_DEVICE_BROKEN,
+ nvmeq->sq_cmds = dma_alloc_coherent(dev->dev,
SQ_SIZE(depth),
&nvmeq->sq_dma_addr);
if (!nvmeq->sq_cmds)
@@ -187,7 +187,7 @@ static int nvme_alloc_queue(struct nvme_dev *dev, int qid, int depth)
return 0;
free_cqdma:
- dma_free_coherent(DMA_DEVICE_BROKEN,
+ dma_free_coherent(dev->dev,
(void *)nvmeq->cqes, nvmeq->cq_dma_addr,
CQ_SIZE(depth));
free_nvmeq:
--
2.47.3
next prev parent reply other threads:[~2026-07-09 7:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 7:22 [PATCH 1/2] nvme: fix PRP pool resize before first use Ahmad Fatoum
2026-07-09 7:22 ` Ahmad Fatoum [this message]
2026-07-10 21:38 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260709072255.510962-2-a.fatoum@barebox.org \
--to=a.fatoum@barebox.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox