mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Luca Lauro via B4 Relay <devnull+famlauro93l.gmail.com@kernel.org>
To: Sascha Hauer <s.hauer@pengutronix.de>,
	 "open list:BAREBOX" <barebox@lists.infradead.org>
Cc: Luca Lauro <famlauro93l@gmail.com>
Subject: [PATCH v4 13/14] ata: ahci: add FLUSH EXT and STANDBY IMMEDIATE support during shutdown
Date: Thu, 13 Aug 2026 17:26:33 +0200	[thread overview]
Message-ID: <20260813-rn102-rn104-series-v4-13-f932ac63efa0@gmail.com> (raw)
In-Reply-To: <20260813-rn102-rn104-series-v4-0-f932ac63efa0@gmail.com>

From: Luca Lauro <famlauro93l@gmail.com>

Some AHCI controllers require ATA FLUSH EXT and STANDBY IMMEDIATE to be
issued before poweroff to ensure data integrity and proper device
shutdown. This patch introduces ahci_port_shutdown(), which sends these
commands using ahci_ata_nodata().

Signed-off-by: Luca Lauro <famlauro93l@gmail.com>
---
 drivers/ata/ahci.c | 46 +++++-----------------------------------------
 1 file changed, 5 insertions(+), 41 deletions(-)

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index c78d1953e4..9ac34b15fe 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -49,6 +49,11 @@
 #define ahci_debug(ahci, fmt, arg...) \
 	dev_dbg(ahci->dev, fmt, ##arg)
 
+#define ATA_CMD_FLUSH_EXT 0xEA
+#define ATA_CMD_STANDBYNOW1 0xE0
+
+static LIST_HEAD(ahci_devices);
+
 static const struct pci_device_id ahci_pci_tbl[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL_EXT, 0x9170) },
 	{ 0, }
@@ -691,47 +696,6 @@ static void ahci_port_shutdown(struct ahci_port *port)
 		ahci_port_info(port, "STANDBY IMMEDIATE failed\n");
 }
 
-/* Full poweroff sequence */
-static void ahci_poweroff(struct poweroff_handler *handler, unsigned long flags)
-{
-	struct ahci_device *ahci;
-	int i, n_ports;
-
-	list_for_each_entry(ahci, &ahci_devices, list) {
-
-		if (!ahci->mmio_base)
-			continue;
-
-		/* FLUSH + STANDBY on all active ports */
-		n_ports = max_t(int, ahci->n_ports, fls(ahci->port_map));
-
-		for (i = 0; i < n_ports; i++) {
-			struct ahci_port *port = &ahci->ports[i];
-
-			if (!(ahci->port_map & (1 << i)))
-				continue;
-
-			ahci_port_shutdown(port);
-		}
-
-		/* (optional) shutsown controller after commands
-		* ahci_shutdown_host(ahci);
-		*/
-	}
-}
-
-static struct poweroff_handler ahci_po_handler = {
-	.poweroff = ahci_poweroff,
-	.priority = 200,   /* higher than gpio-poweroff */
-};
-
-static int ahci_register_poweroff(void)
-{
-	poweroff_handler_register(&ahci_po_handler);
-	return 0;
-}
-postcore_initcall(ahci_register_poweroff);
-
 static __maybe_unused struct of_device_id ahci_dt_ids[] = {
 	{
 		.compatible = "calxeda,hb-ahci",

-- 
2.47.3





  parent reply	other threads:[~2026-08-13 15:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13 15:26 [PATCH v4 00/14] (no cover subject) Luca Lauro via B4 Relay
2026-08-13 15:26 ` [PATCH v4 01/14] ARM: mvebu: add Netgear RN102 support Luca Lauro via B4 Relay
2026-08-13 15:26 ` [PATCH v4 02/14] ARM: mvebu: enable RN102 in mvebu_defconfig Luca Lauro via B4 Relay
2026-08-13 15:26 ` [PATCH v4 03/14] ARM: mvebu: improve Netgear RN104 support Luca Lauro via B4 Relay
2026-08-13 15:26 ` [PATCH v4 04/14] ARM: mvebu: rename PUTC_LL to MVEBU_PUTC_LL Luca Lauro via B4 Relay
2026-08-13 15:26 ` [PATCH v4 05/14] drivers: fan: add fan subsystem, core API and G76x fan controller driver Luca Lauro via B4 Relay
2026-08-13 15:26 ` [PATCH v4 06/14] commands: add fan control command Luca Lauro via B4 Relay
2026-08-13 15:26 ` [PATCH v4 07/14] usb: ehci: add Marvell EHCI host controller driver Luca Lauro via B4 Relay
2026-08-13 15:26 ` [PATCH v4 08/14] usb: ehci: initialize periodic_queue_dma Luca Lauro via B4 Relay
2026-08-13 15:26 ` [PATCH v4 09/14] ata: ahci: add PCI AHCI and Marvell 9170 controller support Luca Lauro via B4 Relay
2026-08-13 15:26 ` [PATCH v4 10/14] ata: ahci: fix zero-length DMA handling Luca Lauro via B4 Relay
2026-08-13 15:26 ` [PATCH v4 11/14] ata: ahci: add helper for ATA commands without data Luca Lauro via B4 Relay
2026-08-13 15:26 ` [PATCH v4 12/14] ata: ahci: improve AHCI port bring-up sequence Luca Lauro via B4 Relay
2026-08-13 15:26 ` Luca Lauro via B4 Relay [this message]
2026-08-13 15:26 ` [PATCH v4 14/14] ata: ahci: cleanup legacy code and remove unused paths Luca Lauro via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260813-rn102-rn104-series-v4-13-f932ac63efa0@gmail.com \
    --to=devnull+famlauro93l.gmail.com@kernel.org \
    --cc=barebox@lists.infradead.org \
    --cc=famlauro93l@gmail.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox