mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH] efi: don't truncate EFI_MEMORY_RUNTIME when setting resource attributes
Date: Tue, 25 Aug 2026 10:53:15 +0200	[thread overview]
Message-ID: <20260825085316.1312263-1-a.fatoum@pengutronix.de> (raw)

resource_set_efi_memory_type_attrs() stored the runtime attribute with

	res->runtime = attrs & EFI_MEMORY_RUNTIME;

but struct resource declares runtime as a one-bit field and
EFI_MEMORY_RUNTIME is bit 63, so the assignment keeps only the low bit of
the masked value and always stores zero. Every caller passing the
attribute silently ended up with a non-runtime resource.

This went unnoticed because the other places marking a resource as
runtime, common/memory.c and efi_allocate_pages(), assign res->runtime =
true directly. The setter is used by efi/payload/iomem.c, which converts
the firmware-provided memory map into resources when barebox runs as an
EFI payload, so barebox lost the runtime flag on every region it imported.

Assisted-by: Claude:opus-5
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 include/efi/memory.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/efi/memory.h b/include/efi/memory.h
index df980a0f348f..74e714099021 100644
--- a/include/efi/memory.h
+++ b/include/efi/memory.h
@@ -71,7 +71,7 @@ static inline void resource_set_efi_memory_type_attrs(struct resource *res,
 						u64 attrs)
 {
 	res->type = type;
-	res->runtime = attrs & EFI_MEMORY_RUNTIME;
+	res->runtime = !!(attrs & EFI_MEMORY_RUNTIME);
 	res->attrs = attrs & ~EFI_MEMORY_RUNTIME;
 	res->flags |= IORESOURCE_TYPE_VALID;
 }
-- 
2.47.3




             reply	other threads:[~2026-08-25  8:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25  8:53 Ahmad Fatoum [this message]
2026-08-28 13:04 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260825085316.1312263-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox