From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH master 1/4] efi: loader: don't truncate the status in efi_init_runtime_variable_supported()
Date: Wed, 26 Aug 2026 11:36:48 +0200 [thread overview]
Message-ID: <20260826093701.2486248-1-a.fatoum@pengutronix.de> (raw)
The return values of efi_set_variable_int() are efi_status_t, i.e. 64-bit
on 64-bit targets with the error bit in the topmost bit. Collecting them
in an int drops that bit, so the value returned to
efi_init_runtime_supported() is a small positive number that no longer
identifies an EFI error: EFI_OUT_OF_RESOURCES arrives as 9.
Callers only compared against EFI_SUCCESS so far, which happens to still
work, but the status is worth printing and the next commit does so.
Assisted-by: Claude:opus-5
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
efi/loader/efi_var_file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/efi/loader/efi_var_file.c b/efi/loader/efi_var_file.c
index 12543bce2851..fbafd901bd0c 100644
--- a/efi/loader/efi_var_file.c
+++ b/efi/loader/efi_var_file.c
@@ -191,8 +191,8 @@ efi_status_t efi_var_from_file(int dirfd, const char *filename)
efi_status_t efi_init_runtime_variable_supported(void)
{
+ efi_status_t ret;
u8 s = 0;
- int ret;
if (!IS_ENABLED(CONFIG_EFI_RT_VOLATILE_STORE))
return EFI_SUCCESS;
--
2.47.3
next reply other threads:[~2026-08-26 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 9:36 Ahmad Fatoum [this message]
2026-08-26 9:36 ` [PATCH master 2/4] efi: loader: fix sign of the error passed to ERR_PTR() Ahmad Fatoum
2026-08-26 9:36 ` [PATCH master 3/4] efi: loader: disk: don't require block-size aligned I/O buffers Ahmad Fatoum
2026-08-26 9:36 ` [PATCH master 4/4] efi: loader: select PRINTF_WCHAR Ahmad Fatoum
2026-08-28 11:59 ` [PATCH master 1/4] efi: loader: don't truncate the status in efi_init_runtime_variable_supported() Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260826093701.2486248-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox