mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Michael Tretter <m.tretter@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
	 Steffen Trumtrar <s.trumtrar@pengutronix.de>,
	 BAREBOX <barebox@lists.infradead.org>
Cc: Michael Tretter <m.tretter@pengutronix.de>
Subject: [PATCH] mci: cadence: adjust name of reset line to dt binding
Date: Mon, 28 Sep 2026 13:56:15 +0200	[thread overview]
Message-ID: <20260928-mci-cadence-sdhci-v1-1-e18fdf9070c0@pengutronix.de> (raw)

The driver has been implemented with a preliminary dt-binding. The
lastest version of the binding patches [0] use the name "combophy" for
the softphy-reset line.

There are no upstream device trees in barebox that use the driver with
the preliminary binding.

Change the driver without compatibility to the preliminary binding to be
compatible with the Agilex 5 device trees that are eventually added by a
device tree sync with the Linux kernel.

[0] https://lore.kernel.org/all/20260901184828.15653-2-tanmay.kathpalia@altera.com/

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
 drivers/mci/cadence-sdhci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mci/cadence-sdhci.c b/drivers/mci/cadence-sdhci.c
index b76c04f5e087..2a4fd5273fef 100644
--- a/drivers/mci/cadence-sdhci.c
+++ b/drivers/mci/cadence-sdhci.c
@@ -424,9 +424,9 @@ static int sdhci_cdns_probe(struct device *dev)
 		return PTR_ERR(priv->rst);
 	}
 
-	priv->softphy_rst = reset_control_get(dev, "softphy-reset");
+	priv->softphy_rst = reset_control_get(dev, "combophy");
 	if (IS_ERR(priv->softphy_rst)) {
-		dev_err(dev, "Invalid reset line 'softphy-reset'.\n");
+		dev_err(dev, "Invalid reset line 'combophy'.\n");
 		return PTR_ERR(priv->softphy_rst);
 	}
 

---
base-commit: 75819f9e196e2da048e96c8589898fdc38ef8e7a
change-id: 20260928-mci-cadence-sdhci-d1dad60b679b

Best regards,
-- 
Michael Tretter <m.tretter@pengutronix.de>




             reply	other threads:[~2026-09-28 14:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28 11:56 Michael Tretter [this message]
2026-09-29  7:11 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260928-mci-cadence-sdhci-v1-1-e18fdf9070c0@pengutronix.de \
    --to=m.tretter@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    --cc=s.trumtrar@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox