mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH] sandbox: hostfile: keep "syscon" compatible on the stickypage
Date: Fri,  2 Oct 2026 14:34:10 +0200	[thread overview]
Message-ID: <20261002123414.2923003-1-a.fatoum@pengutronix.de> (raw)

The stickypage is described as "barebox,stickypage", "syscon", but the
fixup that turns it into a hostfile node replaces the whole compatible
list with just "barebox,hostfile". Nothing can look it up as a syscon
afterwards, so children like a syscon-reboot-mode would fail with
-EINVAL despite the DT saying otherwise.

Let's keep the "syscon" compatible when rewriting the node.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 arch/sandbox/board/hostfile.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/sandbox/board/hostfile.c b/arch/sandbox/board/hostfile.c
index de63ab5a9118..0ad0f76b4210 100644
--- a/arch/sandbox/board/hostfile.c
+++ b/arch/sandbox/board/hostfile.c
@@ -263,7 +263,8 @@ static int of_hostfile_map_fixup(struct device_node *root, void *ctx)
 		}
 
 		of_property_write_string(node, "barebox,filename", filename);
-		of_property_write_string(node, "compatible", "barebox,hostfile");
+		of_property_write_strings(node, "compatible", "barebox,hostfile",
+					  "syscon", NULL);
 	}
 
 	for_each_compatible_node_from(node, root, NULL, "barebox,hostfile") {
-- 
2.47.3




                 reply	other threads:[~2026-10-02 12:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261002123414.2923003-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox