mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Johannes Schneider <johannes.schneider@leica-geosystems.com>
To: barebox@lists.infradead.org
Cc: Marco Felsch <m.felsch@pengutronix.de>,
	Johannes Schneider <johannes.schneider@leica-geosystems.com>
Subject: [PATCH v1 01/14] mfd: hgs-efi: do not claim the name of the EFI loader's device
Date: Sun,  4 Oct 2026 01:19:34 +0000	[thread overview]
Message-ID: <20261004011958.3255011-2-johannes.schneider@leica-geosystems.com> (raw)
In-Reply-To: <20261004011958.3255011-1-johannes.schneider@leica-geosystems.com>

The coprocessor device registers as "efi", the name the EFI loader gives
its own device. With CONFIG_EFI_LOADER on a GS05, whichever registers
second fails, and the EFI loader then panics during late init:

  register_device: already registered efi
  initcall efi_init_params+0x0/0x7c failed: Invalid argument
  PANIC: unable to handle paging request at address 0xffffffffffffffe0

Name the device "hgs-efi", after its driver, and look it up by that
name in the GS05 board code and in hgs_notify_pp4() to sidestep this
naming conflict.

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
---
 arch/arm/boards/hgs-gs05/board.c | 2 +-
 common/boards/hgs/common.c       | 2 +-
 drivers/mfd/hgs-efi.c            | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boards/hgs-gs05/board.c b/arch/arm/boards/hgs-gs05/board.c
index 40dbecae08..f24a764e6c 100644
--- a/arch/arm/boards/hgs-gs05/board.c
+++ b/arch/arm/boards/hgs-gs05/board.c
@@ -123,7 +123,7 @@ hgs_gs05_set_efi_poll_intervall(struct device *efid, u64 new_polling_interval)
 static struct hgs_machine *hgs_gs05_get_board(struct device *dev)
 {
 	u8 buf[HGS_GS05_SERIAL_NUMBER_CHARS] = { };
-	struct device *efi_dev = get_device_by_name("efi");
+	struct device *efi_dev = get_device_by_name("hgs-efi");
 	struct hgs_efi *efi = dev_get_priv(efi_dev->parent);
 	struct hgs_sep_cmd cmd = {
 		.type = HGS_SEP_MSG_TYPE_COMMAND,
diff --git a/common/boards/hgs/common.c b/common/boards/hgs/common.c
index c4a31a2797..0f95bf7bd7 100644
--- a/common/boards/hgs/common.c
+++ b/common/boards/hgs/common.c
@@ -582,7 +582,7 @@ static int hgs_notify_pp4(void)
 	struct device *efi;
 	int ret;
 
-	efi = get_device_by_name("efi");
+	efi = get_device_by_name("hgs-efi");
 	ret = dev_set_param(efi, "cpu_rdy", "1");
 	if (ret)
 		return ret;
diff --git a/drivers/mfd/hgs-efi.c b/drivers/mfd/hgs-efi.c
index 51c0b7ffc9..eb7c267753 100644
--- a/drivers/mfd/hgs-efi.c
+++ b/drivers/mfd/hgs-efi.c
@@ -414,7 +414,7 @@ static int hgs_efi_register_dev(struct hgs_efi *efi)
 	int ret;
 
 	dev->parent = efi->serdev->dev;
-	dev_set_name(dev, "efi");
+	dev_set_name(dev, "hgs-efi");
 	dev->id = DEVICE_ID_SINGLE;
 
 	ret = register_device(dev);
-- 
2.43.0




  reply	other threads:[~2026-10-04  1:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-04  1:19 [PATCH v1 00/14] efi: loader: boot Authenticode-signed UKIs Johannes Schneider
2026-10-04  1:19 ` Johannes Schneider [this message]
2026-10-04  1:19 ` [PATCH v1 02/14] efi: loader: file: report EFI_UNSUPPORTED for volumes without a filesystem Johannes Schneider
2026-10-04  1:19 ` [PATCH v1 03/14] efi: loader: bootm: free the devicetree after installing it Johannes Schneider
2026-10-04  1:19 ` [PATCH v1 04/14] efi: loader: provide EFI_DT_FIXUP_PROTOCOL Johannes Schneider
2026-10-04  1:19 ` [PATCH v1 05/14] efi: loader: pe: add helpers for the image size and a named section Johannes Schneider
2026-10-04  1:19 ` [PATCH v1 06/14] efi: loader: bootm: load only the PE image, not the whole file Johannes Schneider
2026-10-04  1:19 ` [PATCH v1 07/14] efi: loader: bootm: pass the kernel command line to UKIs Johannes Schneider
2026-10-05 17:18   ` Ahmad Fatoum
2026-10-04  1:19 ` [PATCH v1 08/14] efi: loader: verify Authenticode signatures against built-in keys Johannes Schneider
2026-10-05  5:33   ` Ahmad Fatoum
2026-10-05  5:45     ` SCHNEIDER Johannes
2026-10-09  0:07       ` SCHNEIDER Johannes
2026-10-04  1:19 ` [PATCH v1 09/14] efi: loader: authenticode: add a fuzz test Johannes Schneider
2026-10-04  1:19 ` [PATCH v1 10/14] efi: loader: authenticate LoadImage() images when signing is forced Johannes Schneider
2026-10-04  1:19 ` [PATCH v1 11/14] efi: loader: file: expose no filesystem when signed images are forced Johannes Schneider
2026-10-04  1:19 ` [PATCH v1 12/14] bootm: efi: boot signed EFI images " Johannes Schneider
2026-10-04  1:19 ` [PATCH v1 13/14] efi: loader: bootm: install a devicetree for matching UKI devicetrees Johannes Schneider
2026-10-04  1:19 ` [PATCH v1 14/14] efi: loader: bootm: apply overlays carried by a UKI Johannes Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261004011958.3255011-2-johannes.schneider@leica-geosystems.com \
    --to=johannes.schneider@leica-geosystems.com \
    --cc=barebox@lists.infradead.org \
    --cc=m.felsch@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox