From: Sascha Hauer <s.hauer@pengutronix.de>
To: BAREBOX <barebox@lists.infradead.org>
Subject: [PATCH 3/3] fs: legacy: return an error pointer from legacy_get_link()
Date: Mon, 02 Nov 2026 10:08:41 +0100 [thread overview]
Message-ID: <20261102-fs-getlink-fixes-v1-3-c2816b3f5ca8@pengutronix.de> (raw)
In-Reply-To: <20261102-fs-getlink-fixes-v1-0-c2816b3f5ca8@pengutronix.de>
legacy_get_link() returns NULL when the driver's readlink fails, but
readlinkat() checks the returned link only with IS_ERR() before copying
from it, and path lookup takes NULL to mean that the link has already
been followed. Return the driver's error as an error pointer instead,
like legacy_get_link() already does when there is no readlink.
Fixes: b3fbfad7ae ("fs: dentry cache implementation")
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
fs/legacy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/legacy.c b/fs/legacy.c
index dce14706ca..07381d2b5f 100644
--- a/fs/legacy.c
+++ b/fs/legacy.c
@@ -289,7 +289,7 @@ static const char *legacy_get_link(struct dentry *dentry, struct inode *inode)
free(pathname);
if (ret)
- return NULL;
+ return ERR_PTR(ret);
inode->i_link = xstrdup(link);
--
2.47.3
next prev parent reply other threads:[~2026-11-02 9:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 9:08 [PATCH 0/3] fs: return error pointers from ->get_link() on failure Sascha Hauer
2026-11-02 9:08 ` [PATCH 1/3] fs: cramfs: return an error pointer from cramfs_get_link() Sascha Hauer
2026-11-02 9:08 ` [PATCH 2/3] fs: ext4: return an error pointer from ext_get_link() Sascha Hauer
2026-11-02 9:08 ` Sascha Hauer [this message]
2026-11-02 10:21 ` [PATCH 0/3] fs: return error pointers from ->get_link() on failure Ahmad Fatoum
2026-11-02 14:29 ` Sascha Hauer
2026-11-02 13:25 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261102-fs-getlink-fixes-v1-3-c2816b3f5ca8@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox