From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@barebox.org>
Subject: [PATCH 1/2] fs: pstore: don't claim uImages
Date: Tue, 3 Nov 2026 15:32:29 +0100 [thread overview]
Message-ID: <20261103143234.855394-1-a.fatoum@pengutronix.de> (raw)
From: Ahmad Fatoum <a.fatoum@barebox.org>
pstore_driver sets .type = filetype_uimage, likely copied from uimagefs.
pstore doesn't read from a device at all, so it shouldn't claim a type.
This is harmless so far, because file system detection never reports
uImages, but if it did, mounting a uImage without uimagefs enabled would
mount pstore instead. Let's drop the type. Startup code mounts pstore
with an explicit type, so it's not affected.
Assisted-by: Claude:opus-5.5
Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
fs/pstore/fs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/pstore/fs.c b/fs/pstore/fs.c
index 88951632138a..42825d01ce76 100644
--- a/fs/pstore/fs.c
+++ b/fs/pstore/fs.c
@@ -288,7 +288,6 @@ static const struct fs_legacy_ops pstore_ops = {
static struct fs_driver pstore_driver = {
.legacy_ops = &pstore_ops,
- .type = filetype_uimage,
.drv = {
.probe = pstore_probe,
.remove = pstore_remove,
--
2.47.3
next reply other threads:[~2026-11-03 14:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 14:32 Ahmad Fatoum [this message]
2026-11-03 14:32 ` [PATCH 2/2] fs: jffs2: refuse to mount non-MTD devices Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103143234.855394-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=a.fatoum@barebox.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox