Re: [PATCH] net: dsa: realtek: fix Kconfig selects

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 11.05.23 10:35, Antony Pavlov wrote:
> Hi Ahmad!
> 
> On Wed, 3 May 2023 at 13:08, Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
> 
>> Unlike Linux, barebox has no CONFIG_FIXED_PHY or CONFIG_IRQ_DOMAIN.
>> The former is implied by CONFIG_PHYLIB and the latter is unneeded, so
>> revise the Kconfig option accordingly.
> 
> You can drop 'select REGMAP' too.
> 
> It looks like there are several undeclared Kconfig options.
> 
> I used these commands to find them:
> 
> find -iname 'Kconfig*' -type f -exec cat {} ';' | grep "\(^\s*menuconfig
> \|^\s*config \)" | sed "s/^\s*//" | sed "s/^config //"  | sed
> "s/^menuconfig //" | grep "^[A-Z]" | sed "s/ *#.*$//" | sed "s/ if .*$//" |
> sed "s/\s*$//" | sort | uniq  > /tmp/config
> find -iname 'Kconfig*' -type f -exec cat {} ';' | grep "^\s*select " | sed
> "s/^\s*//" | sed "s/^select //" | grep "^[A-Z]" | sed "s/ *#.*$//" | sed
> "s/ if .*$//" | sed "s/\s*$//" | sort | uniq > /tmp/select
> diff -u /tmp/select /tmp/config | grep ^- | grep -v "^---" | sed "s/^-//"
> 
> diff output on the master branch is:
> 
> CONFIG_ARCH_HAS_SJLJ
> CRYPTO_BLKCIPHER
> CRYPTO_DES
> REGMAP

Thanks. I had added scripts/kconfig-lint.py to catch such things, but
it got broken recently by the 32BIT/64BIT rework...

Cheers,
Ahmad

> 
> --
> Best regards,
>   Antony Pavlov
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |