mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: "Barbier, Renaud" <Renaud.Barbier@ametek.com>,
	"Barebox List" <barebox@lists.infradead.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: sha2 digest on ppc
Date: Tue, 22 Mar 2022 09:07:36 +0100	[thread overview]
Message-ID: <32d47eaa-df0b-c949-ffd0-89e19ca1f244@pengutronix.de> (raw)
In-Reply-To: <MN2PR16MB313566652F19867ADB77727F91139@MN2PR16MB3135.namprd16.prod.outlook.com>

Hello Renaud,

On 18.03.22 10:14, Barbier, Renaud wrote:
> Commit 03fb5524b06 has changed the configuration selection for hash algorithm. For instance:
> 
> -config SHA256
> +config HAVE_DIGEST_SHA256
>  	Bool
> 
> This breaks on my PPC platform as the configuration selection has not been changed in crypto/sha2.c
> if (!IS_ENABLED(CONFIG_SHA256))
> 
> Still working on my ARM platform because the algo is registered somewhere else (arch/arm/crypto/sha256_glue.c)
> 
> RENAUD: sha256_digest_register
> RENAUD: sha256_digest_register: ALGO NOT REGISTERED
> ...
> RENAUD: digest_algo_get_by_name: sha256 sha256
> RENAUD: digest_algo_get_by_name: sha224 sha256
> RENAUD: digest_algo_get_by_name: md5 sha256
> FIT: /images/kernel-1/hash-1: hash OK

Indeed. There are other instances as well broken by this.
This already got into a release unfortunately.

Cc += Uwe, who introduced above mentioned commit.

Cheers,
Ahmad

> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2022-03-22  8:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-18  9:14 Barbier, Renaud
2022-03-22  8:07 ` Ahmad Fatoum [this message]
2022-03-22  9:00   ` [PATCH] crypto: Followup to crypto symbol renaming for algo registration Uwe Kleine-König
2022-03-28 10:03     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32d47eaa-df0b-c949-ffd0-89e19ca1f244@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=Renaud.Barbier@ametek.com \
    --cc=barebox@lists.infradead.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --subject='Re: sha2 digest on ppc' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox