From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <sha@pengutronix.de>
Cc: barebox@lists.infradead.org, rcz@pengutronix.de
Subject: Re: [PATCH 2/4] of: reserve: mark runtime firmware code regions specially
Date: Thu, 9 Jun 2022 10:17:38 +0200 [thread overview]
Message-ID: <3882c8e7-c8ff-2d6c-e5fe-7c7f36d3b295@pengutronix.de> (raw)
In-Reply-To: <20220609080547.GF1615@pengutronix.de>
Hello Sascha,
On 09.06.22 10:05, Sascha Hauer wrote:
>> diff --git a/include/of.h b/include/of.h
>> index 46b96277d581..0d125d8256d6 100644
>> --- a/include/of.h
>> +++ b/include/of.h
>> @@ -55,9 +55,13 @@ struct of_reserve_map {
>> uint64_t start[OF_MAX_RESERVE_MAP];
>> uint64_t end[OF_MAX_RESERVE_MAP];
>> int num_entries;
>> + u16 runtime_fw : OF_MAX_RESERVE_MAP;
>
> Please change to:
>
> struct of_reserve_map_entry {
> uint64_t start;
> uint64_t end;
> u32 flags;
> };
>
> struct of_reserve_map {
> struct of_reserve_map_entry[OF_MAX_RESERVE_MAP];
> int num_entries;
> };
Rouven will reuse/replicate this for PBL, so I'd prefer
to go the size conscious route for now.
Cheers,
Ahmad
>
> Sascha
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2022-06-09 8:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 5:43 [PATCH 0/4] of: request reserved memory regions so other code can't Ahmad Fatoum
2022-06-09 5:43 ` [PATCH 1/4] nvmem: rmem: get, don't request, memory region Ahmad Fatoum
2022-06-09 5:43 ` [PATCH 2/4] of: reserve: mark runtime firmware code regions specially Ahmad Fatoum
2022-06-09 8:05 ` Sascha Hauer
2022-06-09 8:17 ` Ahmad Fatoum [this message]
2022-06-09 5:43 ` [PATCH 3/4] of: add of_get_reserve_map stub for !CONFIG_OFTREE Ahmad Fatoum
2022-06-09 9:14 ` Sascha Hauer
2022-06-09 5:43 ` [PATCH 4/4] of: request reserved memory regions so other code can't Ahmad Fatoum
2022-06-09 8:31 ` [PATCH] fixup! " Ahmad Fatoum
2022-06-09 8:31 ` [PATCH 4/4] " Sascha Hauer
2022-06-09 8:36 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3882c8e7-c8ff-2d6c-e5fe-7c7f36d3b295@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=rcz@pengutronix.de \
--cc=sha@pengutronix.de \
--subject='Re: [PATCH 2/4] of: reserve: mark runtime firmware code regions specially' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox