mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: yegorslists@googlemail.com, barebox@lists.infradead.org
Cc: sha@pengutronix.de
Subject: Re: [PATCH] ARM: dts: am335x: update cpsw nodes
Date: Wed, 6 Jul 2022 07:44:54 +0200	[thread overview]
Message-ID: <3a5f9fec-30ff-cd06-7333-ea1e56236322@pengutronix.de> (raw)
In-Reply-To: <20220704114959.15635-1-yegorslists@googlemail.com>

Hello Yegor,

On 04.07.22 13:49, yegorslists@googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> Switch to cpsw switchdev definition.

Both bindings should be supported by the same driver in barebox.
Is this just to align with your Linux DT or did you experience breakage?

Cheers,
Ahmad

> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>  arch/arm/dts/am335x-baltos-minimal.dts | 29 ++++++++++++++++----------
>  1 file changed, 18 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/arm/dts/am335x-baltos-minimal.dts b/arch/arm/dts/am335x-baltos-minimal.dts
> index dff901f050..e55a2d7cbb 100644
> --- a/arch/arm/dts/am335x-baltos-minimal.dts
> +++ b/arch/arm/dts/am335x-baltos-minimal.dts
> @@ -399,33 +399,40 @@
>  	};
>  };
>  
> -&mac {
> +&mac_sw {
>  	pinctrl-names = "default", "sleep";
>  	pinctrl-0 = <&cpsw_default>;
>  	pinctrl-1 = <&cpsw_sleep>;
> -	dual_emac = <1>;
>  
>  	status = "okay";
>  };
>  
> -&davinci_mdio {
> +&davinci_mdio_sw {
> +	status = "okay";
>  	pinctrl-names = "default", "sleep";
>  	pinctrl-0 = <&davinci_mdio_default>;
>  	pinctrl-1 = <&davinci_mdio_sleep>;
>  
> -	status = "okay";
> +	phy1: ethernet-phy@1 {
> +		reg = <7>;
> +		eee-broken-100tx;
> +		eee-broken-1000t;
> +	};
>  };
>  
> -&cpsw_emac0 {
> -	phy_id = <&davinci_mdio>, <0>;
> +&cpsw_port1 {
>  	phy-mode = "rmii";
> -	dual_emac_res_vlan = <1>;
> +	ti,dual-emac-pvid = <1>;
> +	fixed-link {
> +		speed = <100>;
> +		full-duplex;
> +	};
>  };
>  
> -&cpsw_emac1 {
> -	phy_id = <&davinci_mdio>, <7>;
> -	phy-mode = "rgmii-txid";
> -	dual_emac_res_vlan = <2>;
> +&cpsw_port2 {
> +	phy-mode = "rgmii-id";
> +	ti,dual-emac-pvid = <2>;
> +	phy-handle = <&phy1>;
>  };
>  
>  &mmc1 {


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



  parent reply	other threads:[~2022-07-06  5:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-04 11:49 yegorslists
2022-07-05  3:53 ` Sascha Hauer
2022-07-06  5:44 ` Ahmad Fatoum [this message]
2022-07-06  6:13   ` Yegor Yefremov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a5f9fec-30ff-cd06-7333-ea1e56236322@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=sha@pengutronix.de \
    --cc=yegorslists@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox