Re: [PATCH] fs: nfs: Error if a port is unregistered

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 02.02.23 10:33, Jookia wrote:
> On Thu, Feb 02, 2023 at 08:39:48AM +0100, Sascha Hauer wrote:
>> When this happens do we see a meaningful error message on the barebox
>> side? From a feeling I would say -ECONNREFUSED might be a better error
>> code, but I don't know if that's suitable for UDP connections.
> 
> Currently the error looks like this:
> 
> mounting failed with -110
> ERROR: nfs nfs0: probe failed: Connection timed out
> mount: Invalid argument
>     probe-> nfs0
> lookup mount port failed with -110
> ERROR: nfs nfs0: probe failed: Connection timed out
> 
> Now it looks like:
> 
> lookup mount port failed with -2
> ERROR: nfs nfs0: probe failed: No such file or directory
> mount: Invalid argument
>     probe-> nfs0
> 
> Not sure how this could be improved.

Add a pr_warn with a descriptive message?

> 
>> Sascha
> 
> John.
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |