From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Michael Tretter <m.tretter@pengutronix.de>, barebox@lists.infradead.org
Subject: Re: [PATCH 3/3] net: macb: fix compiler warning for 64 bit systems
Date: Thu, 15 Oct 2020 15:29:01 +0200 [thread overview]
Message-ID: <42b7d165-9bc6-cbc6-57f7-9e537906e3df@pengutronix.de> (raw)
In-Reply-To: <20201015132048.420995-3-m.tretter@pengutronix.de>
Hello,
On 10/15/20 3:20 PM, Michael Tretter wrote:
> On arm64 the compiler prints the following warning, when the macb driver
> is enabled:
>
> warning: cast from pointer to integer of different size
>
> Add the same explicit cast as implemented for all other dma addresses in
> the macb driver.
>
> Fixes: befd110b5922 ("net: macb: init multiple dummy TX queues")
I don't think this qualifies as a fix. You just silence the compiler
warning you that your truncate the upper 32 bits of your buffer's
address. This works because your SDRAM's location in physical memory
is below 4G.
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> ---
> drivers/net/macb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index fa530cfe8e4c..188dbf2d8c15 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -365,7 +365,7 @@ static int gmac_init_dummy_tx_queues(struct macb_device *macb)
> MACB_BIT(TX_LAST) | MACB_BIT(TX_USED);
>
> for (i = 1; i < num_queues; i++)
> - gem_writel_queue_TBQP(macb, &macb->gem_q1_descs[0], i - 1);
> + gem_writel_queue_TBQP(macb, (ulong)macb->gem_q1_descs, i - 1);
>
> return 0;
> }
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-10-15 13:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 13:20 [PATCH 1/3] net: macb: reduce DEBUG output to make it more useful Michael Tretter
2020-10-15 13:20 ` [PATCH 2/3] net: macb: adjust clk_tx rate for link speed changes Michael Tretter
2020-10-15 13:20 ` [PATCH 3/3] net: macb: fix compiler warning for 64 bit systems Michael Tretter
2020-10-15 13:29 ` Ahmad Fatoum [this message]
2020-10-15 14:04 ` Michael Tretter
2020-10-15 14:13 ` Ahmad Fatoum
2020-10-19 8:10 ` Sascha Hauer
2020-10-19 8:02 ` [PATCH 1/3] net: macb: reduce DEBUG output to make it more useful Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42b7d165-9bc6-cbc6-57f7-9e537906e3df@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=m.tretter@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox