mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrej Picej <andrej.picej@norik.com>
To: Sascha Hauer <sha@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM: i.MX: xload-gpmi-nand: apply errata 007117
Date: Thu, 21 Jan 2021 13:23:16 +0100	[thread overview]
Message-ID: <435bb8a9-96b8-4a09-1a42-19cc77e42ebf@norik.com> (raw)
In-Reply-To: <20210121091128.GG19063@pengutronix.de>

Hi Sascha,

yes, unfortunately we have. We applied this just because we experienced 
hangs in device booting tests. After this patch the NAND booting 
problems went away. The booting failed during DMA page reading.
I just tested this again and after excluding the changes in this patch 
the device fails at executing DMA commands. The boot fails in 
approximately one out of 10 boots.

Best regards,
Andrej

On 21. 01. 21 10:11, Sascha Hauer wrote:
> On Wed, Jan 20, 2021 at 01:51:07PM +0100, Andrej Picej wrote:
>> During raw NAND booting, GPMI/BCH clock generation might fail due to
>> improper clock gating conditions and consequently booting from NAND will
>> fail. This is caused by silicon errata ERR007117. Apply errata fix
>> workaround before GPMI NAND xload to prevent this from occurring.
>>
>> Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
>> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
>> ---
>>   arch/arm/mach-imx/xload-gpmi-nand.c | 62 +++++++++++++++++++++++++++++
>>   1 file changed, 62 insertions(+)
>>
>> diff --git a/arch/arm/mach-imx/xload-gpmi-nand.c b/arch/arm/mach-imx/xload-gpmi-nand.c
>> index 04f799604..4be6d1890 100644
>> --- a/arch/arm/mach-imx/xload-gpmi-nand.c
>> +++ b/arch/arm/mach-imx/xload-gpmi-nand.c
>> @@ -20,6 +20,8 @@
>>   #include <mach/xload.h>
>>   #include <mach/imx-nand-bcb.h>
>>   #include <linux/mtd/rawnand.h>
>> +#include <mach/imx6-regs.h>
>> +#include <mach/clock-imx6.h>
>>   
>>   /*
>>    * MXS DMA hardware command.
>> @@ -256,6 +258,63 @@ struct mxs_nand_info {
>>   	unsigned long nand_size;
>>   };
>>   
>> +/**
>> + * It was discovered that xloading barebox from NAND sometimes fails. Observed
>> + * behaviour is similar to silicon errata ERR007117 for i.MX6.
> 
> Have you really seen this behaviour? I wonder because the ROM has
> already loaded the initial code that is just running from NAND, so it
> surprises me that we still have to apply clock fixes.
> 
> Sascha
> 

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2021-01-21 12:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 12:51 [PATCH 0/3] GPMI NAND xload for i.MX6 Andrej Picej
2021-01-20 12:51 ` [PATCH 1/3] ARM: i.MX: move BCB structures to header file Andrej Picej
2021-01-20 12:51 ` [PATCH 2/3] ARM: i.MX: implement GPMI NAND xload Andrej Picej
2021-01-20 21:45   ` Roland Hieber
2021-01-21  9:01   ` Sascha Hauer
2021-01-21 10:28     ` Andrej Picej
2021-01-25  9:15       ` Sascha Hauer
2021-01-25  9:43         ` Andrej Picej
2021-01-26 11:40           ` Andrej Picej
2021-01-26 12:08             ` Sascha Hauer
2021-01-26 12:18               ` Andrej Picej
2021-01-20 12:51 ` [PATCH 3/3] ARM: i.MX: xload-gpmi-nand: apply errata 007117 Andrej Picej
2021-01-21  9:11   ` Sascha Hauer
2021-01-21 12:23     ` Andrej Picej [this message]
2021-01-22  8:12       ` Sascha Hauer
2021-01-22  9:47         ` Andrej Picej
2021-01-25  8:57           ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=435bb8a9-96b8-4a09-1a42-19cc77e42ebf@norik.com \
    --to=andrej.picej@norik.com \
    --cc=barebox@lists.infradead.org \
    --cc=sha@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox