mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Roland Hieber <rhi@pengutronix.de>, Ahmad Fatoum <ahmad@a3f.at>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fixup! common: add option for shipping KCONFIG_CONFIG as /env/data/config
Date: Mon, 12 Apr 2021 09:54:25 +0200	[thread overview]
Message-ID: <550a048a-f6e5-d4c0-340a-d7c743f04edf@pengutronix.de> (raw)
In-Reply-To: <20210412074500.dgi2vz7ptkzmrsrk@pengutronix.de>

Hi,

On 12.04.21 09:45, Roland Hieber wrote:
> On Sun, Apr 11, 2021 at 10:39:47PM +0200, Ahmad Fatoum wrote:
>> Doesn't make sense to have this without DEFAULT_ENVIRONMENT_GENERIC_NEW
>> support. Similar options depend on this as well.
>>
>> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> 
> Thanks, this is useful!
> 
> For both:
> Tested-by: Roland Hieber <rhi@pengutronix.de>

Thanks for testing. If you like it, you can check
https://lore.pengutronix.de/barebox/20210412071651.8769-13-a.fatoum@pengutronix.de/T/#u
to see it in action.

It's used to conditionally skip tests if a config option isn't available
(with a fallback to the build-time .config).

Cheers,
Ahmad

> 
>> ---
>>  common/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/common/Kconfig b/common/Kconfig
>> index 2872c80dbf13..bddf802d3bb4 100644
>> --- a/common/Kconfig
>> +++ b/common/Kconfig
>> @@ -943,6 +943,7 @@ config DEFAULT_ENVIRONMENT_GENERIC_NEW_REBOOT_MODE
>>  
>>  config DEFAULT_ENVIRONMENT_GENERIC_NEW_IKCONFIG
>>  	bool "Ship .config as /env/data/config"
>> +	depends on DEFAULT_ENVIRONMENT_GENERIC_NEW
>>  	help
>>  	  This option embeds the used barebox Kconfig .config file into the
>>  	  environment as /env/data/config. This will increases barebox image
>> -- 
>> 2.31.0
>>
>>
>> _______________________________________________
>> barebox mailing list
>> barebox@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/barebox
>>
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2021-04-12  7:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-10 10:45 [PATCH] " Ahmad Fatoum
2021-04-11 20:39 ` [PATCH] fixup! " Ahmad Fatoum
2021-04-12  7:45   ` Roland Hieber
2021-04-12  7:54     ` Ahmad Fatoum [this message]
2021-04-13  6:09 ` [PATCH] " Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550a048a-f6e5-d4c0-340a-d7c743f04edf@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=ahmad@a3f.at \
    --cc=barebox@lists.infradead.org \
    --cc=rhi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox