From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>,
barebox@lists.infradead.org
Subject: Re: [PATCH] net:fec: fixed unaligned access and stack corruption
Date: Thu, 30 Jul 2020 23:23:58 +0200 [thread overview]
Message-ID: <5895f2db-5702-c1f9-c4e2-81bd020da291@pengutronix.de> (raw)
In-Reply-To: <20200730211356.GA10482@pengutronix.de>
Hello Marco,
On 7/30/20 11:13 PM, Marco Felsch wrote:
> Hi,
>
> sorry for jumping in.
No worries,
> On 20-07-11 07:28, Ahmad Fatoum wrote:
>> Ah, I thought the drvdata is pre-populated in Linux. I would rename
>> the new function to device_get_match_data then for alignment with
>> Linux, with the difference that it returns either platform data or
>> device tree driver_data as appropriate.
>
> Linux uses the of_device_get_match_data() [1] for of-based drivers.
>
> [1] https://elixir.bootlin.com/linux/v5.8-rc4/source/drivers/of/device.c#L189
Yes, future barebox device_get_match_data should work with both of
and platform data, that's why I'd drop the of_ prefix.
Cheers,
Ahmad
>
> Regards,
> Marco
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-07-30 21:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 16:01 Enrico Scholz
2020-07-07 17:11 ` Ahmad Fatoum
2020-07-11 5:07 ` Sascha Hauer
2020-07-11 5:13 ` Ahmad Fatoum
2020-07-11 5:20 ` Sascha Hauer
2020-07-11 5:28 ` Ahmad Fatoum
2020-07-14 18:39 ` Sascha Hauer
2020-07-30 21:13 ` Marco Felsch
2020-07-30 21:23 ` Ahmad Fatoum [this message]
2020-07-30 21:33 ` Marco Felsch
2020-07-11 5:12 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5895f2db-5702-c1f9-c4e2-81bd020da291@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=enrico.scholz@sigma-chemnitz.de \
--cc=m.felsch@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox