From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH master 0/3] Fix GCC 11 THUMB2 relocate_to_current_adr miscompile
Date: Thu, 13 Oct 2022 13:53:53 +0200 [thread overview]
Message-ID: <65ff41d2-b355-b009-95c3-85786b3b1a1e@pengutronix.de> (raw)
In-Reply-To: <20221013115214.3bvxg2v3gj653d6s@pengutronix.de>
On 13.10.22 13:52, Marco Felsch wrote:
> Hi Ahmad,
> On 22-10-13, Ahmad Fatoum wrote:
>> TL;DR: GCC can prove that variables aren't supposed to overlap and as
>> such it generated code than readded get_runtime_offset() on top of an
>> already relocated linker-defined variable's address.
>> See PATCH 2/3 for a disassembly of the affected code. Board code can
>> be similarly micompiled, but that's a fix for another day.
>
> I didn't received a 2/3 nor a 1/3 yet. Does it stuck somewhere?
At least lore.barebox.org got it:
https://lore.barebox.org/barebox/20221013090352.562170-1-a.fatoum@pengutronix.de/T/#t
>
> Regards,
> Marco
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2022-10-13 11:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 9:03 Ahmad Fatoum
2022-10-13 9:03 ` [PATCH master 1/3] include: asm-generic: reloc: implement get_unrelocated() Ahmad Fatoum
2022-10-13 9:03 ` [PATCH master 2/3] ARM: cpu: add compiler barrier around unrelocated access Ahmad Fatoum
2022-10-13 9:03 ` [PATCH master 3/3] RISC-V: add compiler barriers around unrelocated accesses Ahmad Fatoum
2022-10-13 10:36 ` Ahmad Fatoum
2022-10-13 11:52 ` [PATCH master 0/3] Fix GCC 11 THUMB2 relocate_to_current_adr miscompile Marco Felsch
2022-10-13 11:53 ` Ahmad Fatoum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65ff41d2-b355-b009-95c3-85786b3b1a1e@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox