Re: [PATCH] bootm: add fitimage command line to bootargs

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hi,

On 8/27/26 4:16 PM, Ahmad Fatoum wrote:
> On 8/27/26 2:16 PM, Thomas Bonnefille wrote:
> Above test doesn't verify signatures though and I believe it would
> actually break. You can verify by setting global.bootm.verify=signature
> after having built with CONFIG_CRYPTO_BUILTIN_DEVELOPMENT_KEYS=y.
> 
> I will Cc you on a RFC patch shortly.

No patch for me, but a FIT spec issue:

https://github.com/open-source-firmware/flat-image-tree/issues/60

The spec appears to be inconsistent.

Thanks!
Ahmad

> 
> Cheers,
> Ahmad
> 
> 
>> +
>> +	pr_info("Using command line from FIT configuration: %s\n", cmdline);
>> +}
>> +
>>  static enum filetype bootm_fit_update_os_header(struct image_data *data)
>>  {
>>  	size_t size;
>> @@ -146,6 +159,8 @@ int bootm_open_fit(struct image_data *data, bool override)
>>  		goto err;
>>  	}
>>  
>> +	bootm_fit_config_cmdline(fit_config);
>> +
>>  	loadable_from_fit_os(data, fit, fit_config);
>>  	if (override)
>>  		data->is_override.os = true;
>>
>> ---
>> base-commit: df1055a2e0ddd3f96939327f2f0eb9db13a2bdc6
>> change-id: 20260827-add-cmdline-fitimage-42f6b2e930c1
>>
>> Best regards,
>> --  
>> Thomas Bonnefille <thomas.bonnefille@bootlin.com>
>>
>>
> 

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |