mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Rouven Czerwinski <r.czerwinski@pengutronix.de>,
	barebox@lists.infradead.org
Subject: Re: [PATCH] mci: imx-esdhc-pbl: initialize fsl_esdhc_host
Date: Thu, 5 Aug 2021 15:52:28 +0200	[thread overview]
Message-ID: <8879968f-3947-b754-1f07-935948e8f248@pengutronix.de> (raw)
In-Reply-To: <20210805082607.1698733-1-r.czerwinski@pengutronix.de>

On 05.08.21 10:26, Rouven Czerwinski wrote:
> Since commit 56ca2c197e71 ("mci: sdhci: Get rid of many register ops")
> the core checks whether there is an explicit write function for the
> host. If the struct is not zero initialized, a bogus value is taken as
> the function, resulting in an unbootable board. Zero initialize the
> structs properly to let the PBL correctly load images. Fixes booting on
> the i.MX8M* board, tested on i.MX8MP EVK.
> 
> Fixes: 56ca2c197e71 ("mci: sdhci: Get rid of many register ops")
> 
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

> ---
>  drivers/mci/imx-esdhc-pbl.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mci/imx-esdhc-pbl.c b/drivers/mci/imx-esdhc-pbl.c
> index c3a8b377e..2e04c78fd 100644
> --- a/drivers/mci/imx-esdhc-pbl.c
> +++ b/drivers/mci/imx-esdhc-pbl.c
> @@ -233,7 +233,7 @@ static int imx8m_esdhc_init(struct fsl_esdhc_host *host,
>  int imx6_esdhc_start_image(int instance)
>  {
>  	struct esdhc_soc_data data;
> -	struct fsl_esdhc_host host;
> +	struct fsl_esdhc_host host = { 0 };
>  
>  	switch (instance) {
>  	case 0:
> @@ -272,7 +272,7 @@ int imx6_esdhc_start_image(int instance)
>  int imx7_esdhc_start_image(int instance)
>  {
>  	struct esdhc_soc_data data;
> -	struct fsl_esdhc_host host;
> +	struct fsl_esdhc_host host = { 0 };
>  
>  	switch (instance) {
>  	case 0:
> @@ -309,7 +309,7 @@ int imx7_esdhc_start_image(int instance)
>  int imx8m_esdhc_load_image(int instance, bool start)
>  {
>  	struct esdhc_soc_data data;
> -	struct fsl_esdhc_host host;
> +	struct fsl_esdhc_host host = { 0 };
>  	int ret;
>  
>  	ret = imx8m_esdhc_init(&host, &data, instance);
> @@ -337,7 +337,7 @@ int imx8m_esdhc_load_image(int instance, bool start)
>  int imx8mp_esdhc_load_image(int instance, bool start)
>  {
>  	struct esdhc_soc_data data;
> -	struct fsl_esdhc_host host;
> +	struct fsl_esdhc_host host = { 0 };
>  	int ret;
>  
>  	ret = imx8m_esdhc_init(&host, &data, instance);
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2021-08-05 13:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05  8:26 Rouven Czerwinski
2021-08-05 13:52 ` Ahmad Fatoum [this message]
2021-08-09 18:10 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8879968f-3947-b754-1f07-935948e8f248@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=r.czerwinski@pengutronix.de \
    --subject='Re: [PATCH] mci: imx-esdhc-pbl: initialize fsl_esdhc_host' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox