From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
Barebox List <barebox@lists.infradead.org>
Cc: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Subject: Re: [PATCH] firmware: Fix dependencies for PBL
Date: Thu, 5 Nov 2020 14:32:41 +0100 [thread overview]
Message-ID: <8e1faa90-2d82-8bcb-b045-cb694a2c1981@pengutronix.de> (raw)
In-Reply-To: <20201105080245.21325-1-s.hauer@pengutronix.de>
Hello Sascha,
On 11/5/20 9:02 AM, Sascha Hauer wrote:
> The firmware object files for PBL have the name %.gen-pbl.o, not
> pbl-%.gen.o. Fix The dependencies so that the object files for PBL
> get rebuilt when the firmware changes.
>
> Fixes: ff047395b9 ("kbuild: rename pbl object pbl-*.o to *.pbl.o")
With this applied, there is one remaining instance:
$ egrep -I --exclude-dir=.git -r 'pbl-\S+\.[ao]' .
./common/Makefile:$(obj)/pbl-imd-barebox.o: include/generated/compile.h
This should be s/pbl-imd-barebox.o/imd-barebox.pbl.o/ as well, right?
> Reported-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> firmware/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/firmware/Makefile b/firmware/Makefile
> index 0d1b445783..cc28c0fc39 100644
> --- a/firmware/Makefile
> +++ b/firmware/Makefile
> @@ -55,7 +55,7 @@ $(patsubst %,$(obj)/%.gen.S, $(fw-external-y)): %: $(wordsize_deps) \
> $(patsubst %,$(obj)/%.gen.o, $(fw-external-y)): $(obj)/%.gen.o: $(fwdir)/%
>
> # The same for pbl:
> -$(patsubst %,$(obj)/pbl-%.gen.o, $(fw-external-y)): $(obj)/pbl-%.gen.o: $(fwdir)/%
> +$(patsubst %,$(obj)/%.gen.pbl.o, $(fw-external-y)): $(obj)/%.gen.pbl.o: $(fwdir)/%
>
> obj-pbl-y += $(patsubst %,%.gen.o, $(fw-external-y))
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-11-05 13:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 8:02 Sascha Hauer
2020-11-05 13:32 ` Ahmad Fatoum [this message]
2020-11-13 7:48 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e1faa90-2d82-8bcb-b045-cb694a2c1981@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=r.czerwinski@pengutronix.de \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox