mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Michael Riesch <michael.riesch@wolfvision.net>
To: Barebox <barebox@lists.infradead.org>
Subject: Handle null pointer returned by of_overlay_fix_path properly
Date: Wed, 22 Jun 2022 10:07:01 +0200	[thread overview]
Message-ID: <95ff064f-aa11-c1ce-9d41-e38f2040c565@wolfvision.net> (raw)

Hi all,

The function of_overlay_fix_path returns NULL in certain error cases but
of_overlay_apply_symbols (which is the only caller) does not check the
return value. For broken overlays this may result in an exception, which
is probably not the best way to deal with this situation. I am not sure
though what would be a good way to handle this error condition. Since
the call happens in a loop, we may want to ignore the symbol in question
and continue? Any thoughts?

Best regards,
Michael



             reply	other threads:[~2022-06-22  8:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-22  8:07 Michael Riesch [this message]
2022-06-29  7:37 ` Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95ff064f-aa11-c1ce-9d41-e38f2040c565@wolfvision.net \
    --to=michael.riesch@wolfvision.net \
    --cc=barebox@lists.infradead.org \
    --subject='Re: Handle null pointer returned by of_overlay_fix_path properly' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox