mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>,
	"barebox@lists.infradead.org" <barebox@lists.infradead.org>,
	Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH v2] kbuild: add dtbs target for building all dtbs of an ARCH
Date: Mon, 5 Oct 2020 10:30:26 +0200	[thread overview]
Message-ID: <961c1e2e-c781-2122-95b2-98fa367bd2eb@pengutronix.de> (raw)
In-Reply-To: <20200916151951.29117-1-a.fatoum@pengutronix.de>

Hello Sascha,

On 9/16/20 5:19 PM, Ahmad Fatoum wrote:
> As described in the documentation, upstream device trees extended by
> barebox should take care to cause compile errors, not runtime errors,
> when the paths they extend disappear. This way, breakage can be easily
> detected when synchronizing the dts/ directory and fixed right then.
> 
> Make this process easier by providing a dtbs target that builds all
> device trees available in arch/$(SRCARCH)/dts/.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> v1 -> v2:
>   - populate $(targets) with device trees to build, so make dtbs does
>     only build dts files changed since the last make dtbs run (Sascha)

Any objections to this patch?

> ---
>  Makefile | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index 906068036715..3bf5cbce32a4 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -998,6 +998,22 @@ include/generated/version.h: FORCE
>  include/generated/utsrelease.h: include/config/kernel.release FORCE
>  	$(call filechk,utsrelease.h)
>  
> +# ---------------------------------------------------------------------------
> +# Devicetree files
> +
> +ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/dts/),)
> +dtstree := arch/$(SRCARCH)/dts
> +endif
> +
> +ifneq ($(dtstree),)
> +
> +PHONY += dtbs
> +all_dtbs += $(patsubst $(srctree)/%.dts,$(objtree)/%.dtb,$(wildcard $(srctree)/$(dtstree)/*.dts))
> +targets += $(all_dtbs)
> +dtbs: $(all_dtbs)
> +
> +endif
> +
>  # ---------------------------------------------------------------------------
>  # Modules
>  
> @@ -1173,6 +1189,10 @@ help:
>  	@$(if $(archhelp),$(archhelp),\
>  		echo '  No architecture specific help defined for $(SRCARCH)')
>  	@echo  ''
> +	@$(if $(dtstree), \
> +		echo '  Devicetree:'; \
> +		echo '    * dtbs             - Build device tree blobs for all boards'; \
> +		echo '')
>  	@$(if $(boards), \
>  		$(foreach b, $(boards), \
>  		printf "  %-24s - Build for %s\\n" $(b) $(subst _defconfig,,$(b));) \
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2020-10-05  8:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-16 15:19 Ahmad Fatoum
2020-10-05  8:30 ` Ahmad Fatoum [this message]
2020-10-07  8:48 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=961c1e2e-c781-2122-95b2-98fa367bd2eb@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    --subject='Re: [PATCH v2] kbuild: add dtbs target for building all dtbs of an ARCH' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox