From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Johannes Zink <j.zink@pengutronix.de>, barebox@lists.infradead.org
Cc: kernel@pengutronix.de, ahmad@a3f.at, afa@pengutronix.de,
patchwork-jzi@pengutronix.de
Subject: Re: [PATCH 1/2] imx-usb-loader: fix compilation if prepare make target was not called before
Date: Fri, 26 May 2023 20:42:07 +0200 [thread overview]
Message-ID: <96e9652f-76c1-3577-368a-ca12f85e8808@pengutronix.de> (raw)
In-Reply-To: <20230526165947.1079052-2-j.zink@pengutronix.de>
On 26.05.23 18:59, Johannes Zink wrote:
> As pointed out in [1], compilation failed if the prepare make
> target was not called before compiling the imx-usb-loader, which caused
> the generated file not to exist when building for the sandbox target and
> broke the build.
>
> After a discussion on the original thread, a different approach has been pursued
> by simply adding utsrelease.h as a dependency to scripts.
>
> [1] https://lore.barebox.org/barebox/20230525181320.2277320-1-ahmad@a3f.at/
>
> Fixes: c1b50061f4b3 ("imx-usb-loader: add commandline option for displaying version number")
> Reported-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Tested-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> Signed-off-by: Johannes Zink <j.zink@pengutronix.de>
>
> ---
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 471bbc2679c8..711cba7bed29 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -972,7 +972,7 @@ include/config/kernel.release: FORCE
> # Carefully list dependencies so we do not try to build scripts twice
> # in parallel
> PHONY += scripts
> -scripts: scripts_basic
> +scripts: scripts_basic include/generated/utsrelease.h
> $(Q)$(MAKE) $(build)=$(@)
>
> # Things we need to do before we recursively start building the kernel
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2023-05-26 18:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 16:59 [PATCH 0/2] imx-usb-loader: fixes in displaying version number Johannes Zink
2023-05-26 16:59 ` [PATCH 1/2] imx-usb-loader: fix compilation if prepare make target was not called before Johannes Zink
2023-05-26 18:42 ` Ahmad Fatoum [this message]
2023-05-26 16:59 ` [PATCH 2/2] imx-usb-loader: also add version information on target tool Johannes Zink
2023-05-30 6:27 ` [PATCH 0/2] imx-usb-loader: fixes in displaying version number Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96e9652f-76c1-3577-368a-ca12f85e8808@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=afa@pengutronix.de \
--cc=ahmad@a3f.at \
--cc=barebox@lists.infradead.org \
--cc=j.zink@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=patchwork-jzi@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox