mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Michael Grzeschik <m.grzeschik@pengutronix.de>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	BAREBOX <barebox@lists.infradead.org>
Subject: Re: [PATCH] video: simplefb-fixup: IORESOURCE_BUSY is deprecated use reserve_resource
Date: Thu, 9 Apr 2026 14:15:43 +0200	[thread overview]
Message-ID: <980fa2e8-c4c9-4cad-acf2-ab8f3656ca7a@pengutronix.de> (raw)
In-Reply-To: <20260409-simple-fixup-v1-1-5c4f16de17bd@pengutronix.de>

On 4/9/26 2:10 PM, Michael Grzeschik wrote:
> Since the IORESOURCE_BUSY was retired, the simple-fixup driver was
> missed to be changed. We fix this and also mark the driver memory as
> reserved.
> 
> Fixes: 191b639dd53d ('resource: retire IORESOURCE_BUSY in favor of resource::type')
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

> ---
>  drivers/video/simplefb-fixup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/simplefb-fixup.c b/drivers/video/simplefb-fixup.c
> index e20f2922445bddcb13a049b2581c4c632289d6ee..94cf5a7884504a2dad80768ebedb413b171be868 100644
> --- a/drivers/video/simplefb-fixup.c
> +++ b/drivers/video/simplefb-fixup.c
> @@ -124,8 +124,8 @@ static int simplefb_create_node(struct device_node *root,
>  		return ret;
>  
>  	res.name = "simple-framebuffer";
> -	res.flags |= IORESOURCE_BUSY;
>  	resource_set_range(&res, screen_base, fbi->screen_size);
> +	reserve_resource(&res);
>  
>  	of_fixup_reserved_memory(root, &res);
>  
> 
> ---
> base-commit: 86269eff785a915cfb96f09d9c7ec81a89d33012
> change-id: 20260409-simple-fixup-d519715f3e5f
> 
> Best regards,

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |




  reply	other threads:[~2026-04-09 12:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-09 12:10 Michael Grzeschik
2026-04-09 12:15 ` Ahmad Fatoum [this message]
2026-04-13  7:29 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=980fa2e8-c4c9-4cad-acf2-ab8f3656ca7a@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=m.grzeschik@pengutronix.de \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox