Re: Is it possible to pass extra device-tree include directory?

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello,

On 7/1/20 10:49 AM, Denis Osterland-Heim wrote:
> Hi,
> 
> so, when I got your point right, only the first option is acceptable.
> The other two would be too open.

Two points:

1) I don't think this is a good idea
2) If we do it though, first option is the more acceptable one to me

> 
> Regards, Denis
> 
> Am Montag, den 29.06.2020, 10:26 +0200 schrieb Ahmad Fatoum:
>> Hello,
>>
>> On 6/26/20 9:12 AM, Denis Osterland-Heim wrote:
>>> Hi Sascha,
>>>
>>> which implementation variant would you prefer?
>>>
>>> 1) target specific flags
>>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
>>> index 9aa8be535f30..6f341a6e3e86 100644
>>> --- a/scripts/Makefile.lib
>>> +++ b/scripts/Makefile.lib
>>> @@ -164,6 +164,7 @@ dtc_cpp_flags  = -Wp,-MD,$(depfile).pre -nostdinc                        \
>>>  		 -I$(srctree)/dts/include                                \
>>>  		 -I$(srctree)/include                                    \
>>>  		 -I$(srctree)/dts/src/                                   \
>>> +		 $(DTC_CPP_FLAGS_$(basetarget).dtb)                      \
>>>  		 -undef -D__DTS__
>>>  
>>>  ifdef CONFIG_BOOTM_FITIMAGE_PUBKEY
>>>
>>> with something like this in arch/arm/dts/Makefile:
>>> DTC_CPP_FLAGS_my-board-name.dtb := -I${PTXDIST_PLATFORMCONFIGDIR}/dts
>>> lwl-dtb-$(CONFIG_MACH_MY_BOARD_NAME) += my-board-name.dtb.o
>>>
>>> So we can clearly state that the device-tree is out of barebox tree.
>>
>> Do you really want to modify your bootloader every time you touch the kernel
>> device tree? Projects I am involved in, have a local patch to dts/ that imports
>> the BSP device trees and then extends then in arch/$ARCH/dts. The dts/ device
>> trees are updated along with bootloader update, when I can retest that the
>> kernel modifications didn't break something unexpected. The kernel device tree
>> changes more often than that.
>>
>> I don't think passing arbitrary options to dtc is something we should encourage.
>>
>> Cheers
>> Ahmad
>>
>>>
>>>
>>> 2) add EXTRA_DTC_CPP_FLAGS to Makefile.lib, to pass it to make
>>>
>>>
>>> 3) add $(patsubst "%",%,$(CONFIG_DTC_CPP_FLAGS)) to Makefile.lib, and a Kconfig option
>>>
>>> diff --git a/common/Kconfig b/common/Kconfig
>>> index 02ef3631e04b..074f25aa6b7f 100644
>>> --- a/common/Kconfig
>>> +++ b/common/Kconfig
>>> @@ -1347,3 +1347,6 @@ config DDR_SPD
>>>  
>>>  config HAVE_ARCH_KASAN
>>>         bool
>>> +
>>> +config DTC_CPP_FLAGS
>>> +       string "extra dtc-cpp flags"
>>>
>>>
>>> Regards Denis
>>>
>>> Am Freitag, den 26.06.2020, 06:49 +0200 schrieb Sascha Hauer:
>>>> Hi Denis,
>>>>
>>>> On Mon, Jun 22, 2020 at 07:42:11AM +0000, Denis Osterland-Heim wrote:
>>>>> Hi,
>>>>>
>>>>> is it possible to pass extra device-tree include directory?
>>>>> For instance "${PTXDIST_PLATFORMCONFIGDIR}/dts" to have a out-of-tree dts only in one place?
>>>>
>>>> I am not aware of any possibility doing this currently.
>>>>
>>>> Regards,
>>>>  Sascha
>>>>
>>>
>>>
>>> Diehl Connectivity Solutions GmbH
>>> Geschäftsführung: Horst Leonberger
>>> Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
>>> Nürnberg: HRB 32315
>>> ___________________________________________________________________________________________________
>>>
>>> Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
>>> Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
>>> Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
>>> - Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter https://www.diehl.com/group/de/transparenz-und-informationspflichten/
>>>
>>> The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
>>> mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited. 
>>> - For general information on data protection and your respective rights please visit https://www.diehl.com/group/en/transparency-and-information-obligations/
>>> _______________________________________________
>>> barebox mailing list
>>> barebox@lists.infradead.org
>>> http://lists.infradead.org/mailman/listinfo/barebox
>>>
>>
>>
> 
> 
> Diehl Connectivity Solutions GmbH
> Geschäftsführung: Horst Leonberger
> Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
> Nürnberg: HRB 32315
> ___________________________________________________________________________________________________
> 
> Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
> Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
> Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
> - Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter https://www.diehl.com/group/de/transparenz-und-informationspflichten/
> 
> The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
> mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited. 
> - For general information on data protection and your respective rights please visit https://www.diehl.com/group/en/transparency-and-information-obligations/
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox