mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Neeraj Pal <neerajpal09@gmail.com>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] Documentation: sandbox.rst: added dhcp network configuration
Date: Wed, 21 Apr 2021 23:15:25 +0530	[thread overview]
Message-ID: <CANi4_RV5d9-FgoJjCebMGn4cjQ_DrqqLs0XdC2wUzn6qFKviHw@mail.gmail.com> (raw)
In-Reply-To: <001dcf38-fff0-703a-012b-7cfb826d8899@pengutronix.de>

Hello Ahmad,

On Wed, Apr 21, 2021 at 5:02 PM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
> Please send this as Git patch, i.e. with a commit message. This is most
> easily done, by using git send-email. Write something in the commit message
> that explains the change, e.g.:
>
>   Network configuration on sandbox requires some extra steps on the host
>   OS. Document these.
>
> And don't forget your Signed-off-by. You should also mark the patch as v2
> (pass -v2 to git send-email if you use that).

Thank you for sharing the information. I didn't use git send-email
before but good to know about it.

>
> I am not sure Sphinx likes it when the line is longer than the
> text. Please adjust and while at it you could drop the "for Sandbox"
> part. The whole file (and resulting page) is about sandbox.
>
> s/sanbox/sandbox/. Do you do do these steps while sandbox is running?
> If so, it might be better written as While sandbox is running, ... etc.
>
> > +through dhcp.
> > +Following configuration tested on Ubuntu 20.04 focal LTS
>
> I think you can safely omit this line, but it doesn't hurt.
>
> The rest looks fine.
>
> Cheers,
> Ahmad

I have made the necessary changes as per your suggestions. Sending a
complete patch through git send-email.

Thanks and regards,
Neeraj

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2021-04-21 17:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-20 18:17 Neeraj Pal
2021-04-21 11:32 ` Ahmad Fatoum
2021-04-21 17:45   ` Neeraj Pal [this message]
2021-04-21 18:08     ` [PATCH v2] Documentation: some extra steps requires for DHCP network configuration for sandbox on the host OS Neeraj Pal
2021-04-22  4:36       ` Oleksij Rempel
2021-04-22  6:45         ` Neeraj Pal
2021-05-08 19:08         ` [PATCH v3] Documentation: boards: sandbox: " Neeraj Pal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANi4_RV5d9-FgoJjCebMGn4cjQ_DrqqLs0XdC2wUzn6qFKviHw@mail.gmail.com \
    --to=neerajpal09@gmail.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --subject='Re: [PATCH] Documentation: sandbox.rst: added dhcp network configuration' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox