mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Alexander Shiyan <eagle.alexander923@gmail.com>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM: boards: Add MyirTech MYD-YA15XC-T development board support
Date: Thu, 31 Aug 2023 09:40:16 +0300	[thread overview]
Message-ID: <CAP1tNvQdQUhy_YcY_afTYQyHhgRsvhY5BEdu+p6Y+3oXVUX9nA@mail.gmail.com> (raw)
In-Reply-To: <aa20d72f-8cb6-7b51-9ae6-2f8d15d6c690@pengutronix.de>

Hello Ahmad.

> Thanks for your patch. A few comments below.
...
> > +ENTRY_FUNCTION(start_stm32mp15x_myir, r0, r1, r2)
> > +{
> > +     void *fdt;
> > +
> > +     stm32mp_cpu_lowlevel_init();
> > +
> > +     if (IS_ENABLED(CONFIG_DEBUG_LL))
> > +             setup_uart();
> > +
> > +     fdt = __dtb_z_stm32mp15x_myirtech_myd_start + get_runtime_offset();
> > +
> > +     stm32mp1_barebox_entry(fdt);
>
> Same question: Do you use an old TF-A or why do you need a specific entry
> point instead of barebox-stm32mp-generic-bl33.img?

Initially, I used the old version of TF-A, to facilitate the first
start-up of the board.
Now I'm using new version and FIP, so yes, this piece of code can be removed.

Thanks for the comments on the patch, I'll rework some parts of the code.

2 Sascha: Is it possible to commit the first two parts of the patch
now to minimize the overall work?



  reply	other threads:[~2023-08-31  6:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-30 10:47 [PATCH 1/3] memory: Add driver for FMC2 External Bus Interface on STM32MP SoCs Alexander Shiyan
2023-08-30 10:47 ` [PATCH 2/3] mtd: nand: Add driver for NAND controller " Alexander Shiyan
2023-08-30 10:47 ` [PATCH 3/3] ARM: boards: Add MyirTech MYD-YA15XC-T development board support Alexander Shiyan
2023-08-30 14:41   ` Ahmad Fatoum
2023-08-31  6:40     ` Alexander Shiyan [this message]
2023-09-04  7:17       ` Sascha Hauer
2023-08-31  9:41     ` Alexander Shiyan
2023-09-05  8:25       ` Ahmad Fatoum
2023-09-11 16:01         ` Ahmad Fatoum
2023-09-11 16:09     ` Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAP1tNvQdQUhy_YcY_afTYQyHhgRsvhY5BEdu+p6Y+3oXVUX9nA@mail.gmail.com \
    --to=eagle.alexander923@gmail.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox