Re: [PATCH] of: partition: moan if adding a partition failed

[Alexander Shiyan <eagle.alexander923@gmail.com>]

Hello.
Can you fix also double semicolon at line:
new->device_node = node;;

пт, 6 янв. 2023 г. в 18:03, Ulrich Ölmann <u.oelmann@pengutronix.de>:
>
> Do not silently continue if e.g. the label of a partition defined in the
> devicetree collides with the name of a partition defined in a GPT on the device.
>
> Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
> ---
>  drivers/of/partition.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/of/partition.c b/drivers/of/partition.c
> index abbda674d6cb..b414985555b4 100644
> --- a/drivers/of/partition.c
> +++ b/drivers/of/partition.c
> @@ -67,8 +67,10 @@ struct cdev *of_parse_partition(struct cdev *cdev, struct device_node *node)
>         filename = basprintf("%s.%s", cdev->name, partname);
>
>         new = devfs_add_partition(cdev->name, offset, size, flags, filename);
> -       if (IS_ERR(new))
> +       if (IS_ERR(new)) {
> +               pr_err("Adding partition %s failed: %pe\n", filename, new);
>                 new = NULL;
> +       }
>
>         if (new)
>                 new->device_node = node;;
> --
> 2.30.2
>
>