mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Alessandro Rubini <rubini-list@gnudd.com>
To: s.hauer@pengutronix.de
Cc: barebox@lists.infradead.org
Subject: Re: NFSv4 boot support?
Date: Sat, 9 Mar 2024 11:01:56 +0100	[thread overview]
Message-ID: <ZewzlAE4rg3ZNZks@arcana.i.gnudd.com> (raw)
In-Reply-To: <ZernJsdi43QXwuVr@pengutronix.de>

Sascha:
> In order to get an idea of how routing is supposed to work I had to look
> around in the code. It's really a pain to see and I really don't want to
> have to debug it. The combination of two spaces indentation and a huge
> #ifdef density makes it really hard to read.

Indentation is affordable. We understand different people make different
choices (but I always suggest to read Linus' coding style guide, where every
choice is explained).

ifdef is a plague. There's almost no reason to use it nowadays, but I
see it had it's role when memory and processing power was so limited.

> From that experience I can understand your concerns about lwIP.

:)

Thanks a lot for taking a serious look. I never used it myself, I only
looked at the code and heard from mates who had to make their hands
dirty.

I love what Antony did, but I admit I didn't test it. My own plague is
being late with deliverables and with life in general -- but I'm sure
I'm not alone.

thanks
/alessandro
-- 
  +39-0382-529554 sempre, solo se ci sono
  +39-349-2689041 sempre, solo se c'e` campo



  parent reply	other threads:[~2024-03-09 10:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31 21:03 Dan Shelton
2024-01-31 21:37 ` Ahmad Fatoum
2024-02-05  9:59   ` Antony Pavlov
2024-02-17  8:51     ` Ahmad Fatoum
2024-02-19  2:17       ` Dan Shelton
2024-02-20 14:17         ` Ahmad Fatoum
2024-02-20 15:28           ` Uwe Kleine-König
2024-02-19 21:43       ` Antony Pavlov
2024-02-20 13:53       ` Alessandro Rubini
2024-02-26 12:17         ` Ahmad Fatoum
2024-03-08 10:23         ` Sascha Hauer
2024-03-09 10:01         ` Alessandro Rubini [this message]
2024-02-28  7:26       ` Antony Pavlov
2024-02-28  9:20         ` Sascha Hauer
2024-02-28 11:50           ` Antony Pavlov
2024-02-28 12:27             ` Sascha Hauer
2024-02-05 18:41   ` Antony Pavlov
2024-02-06  4:40     ` Dan Shelton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZewzlAE4rg3ZNZks@arcana.i.gnudd.com \
    --to=rubini-list@gnudd.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox