Re: [PATCH] ARM: tqmls1046a: Add Arkona AT300 support

[Sascha Hauer <s.hauer@pengutronix.de>]

On Tue, Apr 07, 2026 at 01:01:17PM +0200, Steffen Trumtrar wrote:
> diff --git a/arch/arm/boards/tqmls1046a/board.c b/arch/arm/boards/tqmls1046a/board.c
> index bce1838dbc..3c09bcdbf7 100644
> --- a/arch/arm/boards/tqmls1046a/board.c
> +++ b/arch/arm/boards/tqmls1046a/board.c
> @@ -81,7 +81,11 @@ static int tqmls1046a_postcore_init(void)
>  	}
>  
>  	ls1046a_bbu_mmc_register_handler("sd", "/dev/mmc0.barebox", sd_bbu_flags);
> -	ls1046a_bbu_qspi_register_handler("qspi", "/dev/qspiflash0.barebox", qspi_bbu_flags);
> +	ls1046a_bbu_qspi_register_handler("qspi", "/dev/qspiflash0.barebox",
> +					  qspi_bbu_flags);
> +	ls1046a_bbu_qspi_register_handler("qspi-alternate",
> +					  "/dev/qspiflash1.barebox-alternate",
> +					  0);

Is this part of the TQ SoM or Arkona specific? If the latter can we
avoid registering it for the other variants?


> diff --git a/arch/arm/boards/tqmls1046a/rcwtool-at300.c b/arch/arm/boards/tqmls1046a/rcwtool-at300.c
> new file mode 100644
> index 0000000000..a68023b612
> --- /dev/null
> +++ b/arch/arm/boards/tqmls1046a/rcwtool-at300.c

This is handy to have and ideally the rcw values would be automatically
generated during compilation, but let's not put too much effort in this.
Can you move the code to a include file in scripts/include/ so that the
rcwtool-at300.c becomes:

#include <rcwtool.h>

int main(void)
{
	printf("# RCW values:\n");
	printf("\n");

	set_val(SYS_PLL_CFG              ,       0);
	...

	print_rcw();
}

That way we could reuse it for other boards. Also add some comment to
the header what it is and how it's used.

> +/dts-v1/;
> +
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/gpio/gpio.h>
> +
> +#include <arm64/freescale/fsl-ls1046a-tqmls1046a.dtsi>
> +#include "fsl-ls1046a.dtsi"
> +
> +/ {
> +	model = "TQ TQMLS1046A SoM on Arkona AT300 board";
> +	compatible = "arkona,at300", "tq,ls1046a-tqmls1046a", "fsl,ls1046a";
> +
> +	barebox,disable-deep-probe;

Is that needed? Why?

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |