From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <eagle.alexander923@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] bootm: filter out "<NULL>" rootopts to avoid kernel cmdline noise
Date: Fri, 17 Apr 2026 10:44:49 +0200 [thread overview]
Message-ID: <aeHzAfUsNYQL3S4h@pengutronix.de> (raw)
In-Reply-To: <20260416125512.3275056-1-eagle.alexander923@gmail.com>
Hi Alexander,
On Thu, Apr 16, 2026 at 03:55:12PM +0300, Alexander Shiyan wrote:
> When rootopts is set to the literal string "<NULL>" (e.g., due to a
> missing or invalid value in cdev_get_linux_root_and_opts), the resulting
> kernel command line contains "root=/dev/... <NULL>", which is invalid
> and may cause boot failures or confusion.
>
> This patch checks for the "<NULL>" string in rootopts and replaces it
> with NULL before calling format_root_bootarg(), effectively omitting
> the erroneous token from the command line.
I would rather avoid setting it to "<NULL>" in the first place.
Does the patch I just sent help or is there another place where this
happens?
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2026-04-17 8:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 12:55 Alexander Shiyan
2026-04-17 8:44 ` Sascha Hauer [this message]
2026-04-17 11:03 ` Alexander Shiyan
2026-04-20 7:58 ` Sascha Hauer
2026-04-17 11:11 ` Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeHzAfUsNYQL3S4h@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=eagle.alexander923@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox