From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: barebox@lists.infradead.org, jbe@pengutronix.de, ore@pengutronix.de
Subject: Re: [PATCH] ARM: dts: skov-imx6: fix wrong display-timings native-mode binding
Date: Tue, 20 Dec 2022 10:25:23 +0100 [thread overview]
Message-ID: <b59fa2c3-929e-7ad8-1526-a903be5b6643@pengutronix.de> (raw)
In-Reply-To: <Y6DlHesIliQCtP3N@ravnborg.org>
On 19.12.22 23:26, Sam Ravnborg wrote:
> Hi Ahmad.
>
> On Mon, Dec 19, 2022 at 07:18:39PM +0100, Ahmad Fatoum wrote:
>> The value of the native-mode property is supposed to be a phandle to
>> the entry in question, but instead the full node path was used because
>> the <angle brackets> were missing. Fix this. This should not involve any
>> functional change as the default mode would've been the first element,
>> which is the same element the malformed native-mode now points at.
>>
>> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>> ---
>> arch/arm/dts/imx6qdl-skov-imx6.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/dts/imx6qdl-skov-imx6.dtsi b/arch/arm/dts/imx6qdl-skov-imx6.dtsi
>> index f4610ee1e7ba..156722b95a3c 100644
>> --- a/arch/arm/dts/imx6qdl-skov-imx6.dtsi
>> +++ b/arch/arm/dts/imx6qdl-skov-imx6.dtsi
>> @@ -146,7 +146,7 @@
>> };
>>
>> display-timings {
>> - native-mode = &l2rt;
>> + native-mode = <&l2rt>;
>
> The fix is OK, but could you also fix the other similar bugs in the
> tree?
>
> A quick grep identified the following that all looks wrong:
>
> arch/arm/dts/imx6q-var-custom.dts: native-mode = &claawvga;
> arch/arm/dts/imx6qdl-skov-imx6.dtsi: native-mode = &l2rt
> arch/arm/dts/imx6qdl-skov-imx6.dtsi: native-mode = &mi1010ait_1cp1;
Yes, I can do that.
> I took a quick look, and to my surprise I found no similar bugs in the
> kernel.
The power of machine readable (and checkable) bindings :)
Thanks,
Ahmad
>
> Sam
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2022-12-20 9:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 18:18 Ahmad Fatoum
2022-12-19 22:26 ` Sam Ravnborg
2022-12-20 9:25 ` Ahmad Fatoum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b59fa2c3-929e-7ad8-1526-a903be5b6643@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jbe@pengutronix.de \
--cc=ore@pengutronix.de \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox