mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <sha@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 06/14] common: add generic machine partitions interface
Date: Wed, 14 Apr 2021 12:20:42 +0200	[thread overview]
Message-ID: <b85462ec-1b74-6d16-8263-0471fb74877b@pengutronix.de> (raw)
In-Reply-To: <20210414100848.GT19819@pengutronix.de>

Hi,

On 14.04.21 12:08, Sascha Hauer wrote:
> On Tue, Apr 13, 2021 at 12:34:54AM +0200, Ahmad Fatoum wrote:
>> Both Fastboot and DFU have their own global variables that allow
>> specifying the partitions that can be flashed via the environment.
>> With the upcoming addition of the USB mass storage gadget, we will need
>> some way to define the partitions there as well.
>>
>> Instead of adding yet another way download method-specific variable,
>> add a generic machine.partitions variable that can be specified on a
>> per-board basis and can be used for all methods.
>>
>> Existing variables will still remain for backwards-compatibility, but
>> when unset, it should fall back to this new parameter. This is done
>> if the follow-up patches.
>>
>> +static int machine_partitions_var_init(void)
>> +{
>> +	struct param_d *param;
>> +
>> +	machine_partitions = file_list_parse("");
>> +	param = dev_add_param_file_list(of_get_machine(), "partitions",
>> +					NULL, NULL, &machine_partitions, NULL);
> 
> Why machine.partitions and not global.something? What's the very good
> reason to open up another namespace for configuration variables?

I'll go with global.system.partitions. That way it's clear it's machine-specific
(system) and it's still within global.*.

Looking forward to any other feedback before I send v2.

Cheers,
Ahmad

> 
> Sascha
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2021-04-14 10:21 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-12 22:34 [PATCH 00/14] usb: gadget: refactor to allow easier extension Ahmad Fatoum
2021-04-12 22:34 ` [PATCH 01/14] show_progress: add system wide progress stage notifier Ahmad Fatoum
2021-04-15  7:29   ` Sascha Hauer
2021-04-15  7:39     ` Ahmad Fatoum
2021-04-12 22:34 ` [PATCH 02/14] common: console: add log_dprint to print to file descriptor Ahmad Fatoum
2021-04-15  7:25   ` Sascha Hauer
2021-04-15  7:43     ` Ahmad Fatoum
2021-04-12 22:34 ` [PATCH 03/14] string: implement strstarts along with strends Ahmad Fatoum
2021-04-12 22:34 ` [PATCH 04/14] vsprintf: introduce %m shorthand for "%s", strerror(errno) Ahmad Fatoum
2021-04-12 22:34 ` [PATCH 05/14] param: introduce file-list parameter type Ahmad Fatoum
2021-04-12 22:34 ` [PATCH 06/14] common: add generic machine partitions interface Ahmad Fatoum
2021-04-14 10:08   ` Sascha Hauer
2021-04-14 10:20     ` Ahmad Fatoum [this message]
2021-04-12 22:34 ` [PATCH 07/14] fastboot: handle ill-named partitions gracefully Ahmad Fatoum
2021-04-12 22:34 ` [PATCH 08/14] usb: gadget: dfu: change status message to info log level Ahmad Fatoum
2021-04-12 22:34 ` [PATCH 09/14] usbgadget: autostart: fix indeterminism around usbgadget.autostart Ahmad Fatoum
2021-04-12 22:34 ` [PATCH 10/14] usbgadget: allow DFU and Fastboot functions to coexist Ahmad Fatoum
2021-04-12 22:34 ` [PATCH 11/14] fastboot/dfu: use machine partitions as fall back Ahmad Fatoum
2021-04-12 22:35 ` [PATCH 12/14] bbu: add function to directly add handlers into file_list Ahmad Fatoum
2021-04-12 22:35 ` [PATCH 13/14] file_list: add file_list_detect_all() Ahmad Fatoum
2021-04-12 22:35 ` [PATCH 14/14] common: make FILE_LIST feature unconditional Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b85462ec-1b74-6d16-8263-0471fb74877b@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=sha@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox